Merge pull request #2961 from evazion/fix-move-favs-user-assoc

Fix exception when moving favorites

app/models/favorite.rb

@@ -1,5 +1,6 @@
 class Favorite < ActiveRecord::Base
   belongs_to :post
+  belongs_to :user
   scope :for_user, lambda {|user_id| where("user_id % 100 = #{user_id.to_i % 100} and user_id = #{user_id.to_i}")}
   attr_accessible :user_id, :post_id
 

app/models/post.rb

@@ -1282,9 +1282,11 @@ class Post < ActiveRecord::Base
     def give_favorites_to_parent
       return if parent.nil?
 
-      favorites.each do |fav|
-        remove_favorite!(fav.user)
-        parent.add_favorite!(fav.user)
+      transaction do
+        favorites.each do |fav|
+          remove_favorite!(fav.user)
+          parent.add_favorite!(fav.user)
+        end
       end
     end