hide index fields from api; closes #1739

app/models/artist.rb

@@ -306,6 +306,24 @@ class Artist < ActiveRecord::Base
     end
   end
 
+  module ApiMethods
+    def hidden_attributes
+      super + [:other_names_index]
+    end
+
+    def legacy_api_hash
+      return {
+        :id => id,
+        :name => name,
+        :other_names => other_names,
+        :group_name => group_name,
+        :urls => artist_urls.map {|x| x.url},
+        :is_active => is_active?,
+        :updater_id => 0
+      }
+    end
+  end
+
   include UrlMethods
   include NameMethods
   include GroupMethods
@@ -315,6 +333,7 @@ class Artist < ActiveRecord::Base
   include TagMethods
   include BanMethods
   extend SearchMethods
+  include ApiMethods
 
   def status
     if is_banned? && is_active?
@@ -328,18 +347,6 @@ class Artist < ActiveRecord::Base
     end
   end
 
-  def legacy_api_hash
-    return {
-      :id => id,
-      :name => name,
-      :other_names => other_names,
-      :group_name => group_name,
-      :urls => artist_urls.map {|x| x.url},
-      :is_active => is_active?,
-      :updater_id => 0
-    }
-  end
-
   def initialize_creator
     self.creator_id = CurrentUser.user.id
   end

app/models/comment.rb

@@ -140,6 +140,10 @@ class Comment < ActiveRecord::Base
   def editable_by?(user)
     creator_id == user.id || user.is_janitor?
   end
+
+  def hidden_attributes
+    super + [:body_index]
+  end
 end
 
 Comment.connection.extend(PostgresExtensions)

app/models/dmail.rb

@@ -188,4 +188,8 @@ class Dmail < ActiveRecord::Base
   def visible_to?(user)
     user.is_moderator? || owner_id == user.id
   end
+
+  def hidden_attributes
+    super + [:message_index]
+  end
 end

app/models/forum_post.rb

@@ -161,4 +161,8 @@ class ForumPost < ActiveRecord::Base
       x.body = x.quoted_response
     end
   end
+
+  def hidden_attributes
+    super + [:text_index]
+  end
 end

app/models/forum_topic.rb

@@ -96,4 +96,8 @@ class ForumTopic < ActiveRecord::Base
   def presenter(forum_posts)
     @presenter ||= ForumTopicPresenter.new(self, forum_posts)
   end
+  
+  def hidden_attributes
+    super + [:text_index]
+  end
 end

app/models/note.rb

@@ -61,6 +61,10 @@ class Note < ActiveRecord::Base
   end
 
   module ApiMethods
+    def hidden_attributes
+      super + [:body_index]
+    end
+
     def serializable_hash(options = {})
       options ||= {}
       options[:except] ||= []

app/models/wiki_page.rb

@@ -58,6 +58,10 @@ class WikiPage < ActiveRecord::Base
   end
 
   module ApiMethods
+    def hidden_attributes
+      super + [:body_index]
+    end
+
     def serializable_hash(options = {})
       options ||= {}
       options[:except] ||= []