jaculabilis/danbooru
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #4487 from BrokenEagle/fix-invalid-url

Browse Source 
Fix invalid artist URLs being allowed
This commit is contained in:
evazion
2020-06-29 17:46:13 -05:00
committed by GitHub
parent f5c9a78797 ed9135bcf3
commit 3d90414e06
2 changed files with 29 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
test/unit/artist_url_test.rb
View File

@@ -24,10 +24,18 @@ class ArtistUrlTest < ActiveSupport::TestCase
end
should "disallow invalid urls" do
url = FactoryBot.build(:artist_url, url: "www.example.com")
urls = [
FactoryBot.build(:artist_url, url: "www.example.com"),
FactoryBot.build(:artist_url, url: ":www.example.com"),
FactoryBot.build(:artist_url, url: "http://http://www.example.com"),
]
assert_equal(false, url.valid?)
assert_match(/must begin with http/, url.errors.full_messages.join)
assert_equal(false, urls[0].valid?)
assert_match(/must begin with http/, urls[0].errors.full_messages.join)
assert_equal(false, urls[1].valid?)
assert_match(/is malformed/, urls[1].errors.full_messages.join)
assert_equal(false, urls[2].valid?)
assert_match(/that does not contain a dot/, urls[2].errors.full_messages.join)
end
should "always add a trailing slash when normalized" do