Update test factories to run without input of instances

test/factories/forum_post.rb

@@ -1,6 +1,7 @@
 FactoryBot.define do
   factory(:forum_post) do
     creator
+    topic factory: :forum_topic
     body {FFaker::Lorem.sentences.join(" ")}
   end
 end

test/factories/mod_action.rb

@@ -2,5 +2,6 @@ FactoryBot.define do
   factory(:mod_action) do
     creator :factory => :user
     description {"1234"}
+    category {"other"}
   end
 end

test/factories/post_disapproval.rb

@@ -1,7 +1,7 @@
 FactoryBot.define do
   factory(:post_disapproval) do
-    user
-    post
+    user factory: :moderator_user
+    post factory: :post, is_pending: true
     reason { PostDisapproval::REASONS.sample }
     message { FFaker::Lorem.sentence }
   end

test/factories/post_flag.rb

@@ -1,6 +1,6 @@
 FactoryBot.define do
   factory(:post_flag) do
-    creator
+    creator factory: :user, created_at: 2.weeks.ago
     post
     reason {"xxx"}
     is_resolved {false}

test/factories/post_replacement.rb

@@ -1,5 +1,6 @@
 FactoryBot.define do
   factory(:post_replacement) do
+    post factory: :post, source: FFaker::Internet.http_url
     original_url { FFaker::Internet.http_url }
     replacement_url { FFaker::Internet.http_url }
   end

test/factories/post_vote.rb

@@ -1,6 +1,6 @@
 FactoryBot.define do
   factory(:post_vote) do
-    user
+    user factory: :gold_user
     post
     score { [-1, 1].sample }
   end

test/factories/tag_alias.rb

@@ -1,8 +1,8 @@
 FactoryBot.define do
   factory :tag_alias do
     creator
-    antecedent_name {"aaa"}
-    consequent_name {"bbb"}
+    antecedent_name {"#{FFaker::Name.first_name.downcase}#{rand(1000)}"}
+    consequent_name {"#{FFaker::Name.first_name.downcase}#{rand(1000)}"}
     status {"active"}
     skip_secondary_validations {true}
   end

test/factories/tag_implication.rb

@@ -1,8 +1,8 @@
 FactoryBot.define do
   factory :tag_implication do
     creator
-    antecedent_name {"aaa"}
-    consequent_name {"bbb"}
+    antecedent_name {"#{FFaker::Name.first_name.downcase}#{rand(1000)}"}
+    consequent_name {"#{FFaker::Name.first_name.downcase}#{rand(1000)}"}
     status {"active"}
     skip_secondary_validations {true}
   end