BURs: don't allow edits to approved scripts

Also fix bad formatting for non-admins in BUR index
This commit is contained in:
nonamethanks
2022-06-01 14:07:30 +02:00
parent 1e78b97eb8
commit 5932d8d3a3
2 changed files with 4 additions and 4 deletions

View File

@@ -6,7 +6,7 @@ class BulkUpdateRequestPolicy < ApplicationPolicy
end
def update?
unbanned? && (user.is_admin? || record.user_id == user.id)
unbanned? && !record.is_approved? && (user.is_admin? || record.user_id == user.id)
end
def approve?

View File

@@ -1,9 +1,9 @@
<%# bur %>
<%= link_to_if policy(bur).approve?, "Approve", approve_bulk_update_request_path(bur), remote: true, method: :post, "data-confirm": "Are you sure you want to approve this bulk update request?" %> |
<%= link_to_if policy(bur).approve?, "Approve", approve_bulk_update_request_path(bur), remote: true, method: :post, "data-confirm": "Are you sure you want to approve this bulk update request?" %>
<% if policy(bur).destroy? %>
<%= link_to "Reject", bur, remote: true, method: :delete, "data-confirm": "Are you sure you want to reject this bulk update request?" %> |
| <%= link_to "Reject", bur, remote: true, method: :delete, "data-confirm": "Are you sure you want to reject this bulk update request?" %>
<% end %>
<% if policy(bur).update? %>
<%= link_to "Edit", edit_bulk_update_request_path(bur), :"data-shortcut" => "e" %>
| <%= link_to "Edit", edit_bulk_update_request_path(bur), :"data-shortcut" => "e" %>
<% end %>