Fix #5310: "Details" on disapproval dropdown leads to a broken url.

This commit is contained in:
evazion
2022-10-24 01:58:28 -05:00
parent 0d835983ce
commit 5b19e544cf
3 changed files with 28 additions and 4 deletions

View File

@@ -18,6 +18,14 @@ class PostDisapprovalsController < ApplicationController
respond_with(@post_disapprovals)
end
def show
@post_disapproval = authorize PostDisapproval.find(params[:id])
respond_with(@post_disapproval) do |format|
format.html { redirect_to post_disapprovals_path(search: { id: @post_disapproval.id }) }
end
end
def edit
@post_disapproval = authorize PostDisapproval.find(params[:id])
respond_with(@post_disapproval)

View File

@@ -117,10 +117,8 @@
<% end %>
<% end %>
<% if policy(event).can_see_creator? %>
<% menu.item do %>
<%= link_to "Details", event.model %>
<% end %>
<% menu.item do %>
<%= link_to "Details", event.model %>
<% end %>
<% end %>
<% end %>

View File

@@ -86,6 +86,24 @@ class PostDisapprovalsControllerTest < ActionDispatch::IntegrationTest
end
end
context "show action" do
setup do
@disapproval = create(:post_disapproval)
end
should "render for html" do
get post_disapproval_path(@disapproval)
assert_redirected_to post_disapprovals_path(search: { id: @disapproval.id })
end
should "render for json" do
get post_disapproval_path(@disapproval), as: :json
assert_response :success
end
end
context "update action" do
setup do
@post = create(:post, is_pending: true)