Remove uses of string.mb_chars.downcase.

`string.mb_chars.downcase` was used to correctly downcase Unicode
characters when downcasing strings in Ruby <2.4. This hasn't been needed
since Ruby 2.4.
This commit is contained in:
evazion
2022-02-05 13:27:38 -06:00
parent a3ef7bf573
commit 6ff5ae1ce8
7 changed files with 7 additions and 8 deletions

View File

@@ -64,7 +64,7 @@ class Artist < ApplicationRecord
concerning :NameMethods do
class_methods do
def normalize_name(name)
name.to_s.mb_chars.downcase.strip.gsub(/ /, "_").to_s
name.to_s.downcase.strip.gsub(/ /, "_").to_s
end
def normalize_other_names(other_names)

View File

@@ -86,7 +86,7 @@ class Pool < ApplicationRecord
end
def self.normalize_name_for_search(name)
normalize_name(name).mb_chars.downcase
normalize_name(name).downcase
end
def self.named(name)

View File

@@ -91,7 +91,7 @@ class PoolVersion < ApplicationRecord
end
def self.normalize_name_for_search(name)
normalize_name(name).mb_chars.downcase
normalize_name(name).downcase
end
def previous

View File

@@ -173,7 +173,7 @@ class Tag < ApplicationRecord
class_methods do
def normalize_name(name)
name.to_s.mb_chars.downcase.strip.tr(" ", "_").to_s
name.to_s.downcase.strip.tr(" ", "_").to_s
end
def create_for_list(names)

View File

@@ -33,8 +33,8 @@ class TagRelationship < ApplicationRecord
validate :antecedent_and_consequent_are_different
def normalize_names
self.antecedent_name = antecedent_name.mb_chars.downcase.tr(" ", "_")
self.consequent_name = consequent_name.mb_chars.downcase.tr(" ", "_")
self.antecedent_name = antecedent_name.downcase.tr(" ", "_")
self.consequent_name = consequent_name.downcase.tr(" ", "_")
end
def is_rejected?

View File

@@ -187,7 +187,7 @@ class User < ApplicationRecord
end
def normalize_name(name)
name.to_s.mb_chars.downcase.strip.tr(" ", "_").to_s
name.to_s.downcase.strip.tr(" ", "_").to_s
end
end

View File

@@ -73,7 +73,6 @@ class TagAliasTest < ActiveSupport::TestCase
ta = create(:tag_alias, antecedent_name: "aaa", consequent_name: "bbb")
assert_equal(["bbb"], TagAlias.to_aliased("aaa"))
assert_equal(["bbb"], TagAlias.to_aliased("aaa".mb_chars))
assert_equal(["bbb", "ccc"], TagAlias.to_aliased(["aaa", "ccc"]))
assert_equal(["ccc", "bbb"], TagAlias.to_aliased(["ccc", "bbb"]))
assert_equal(["bbb", "bbb"], TagAlias.to_aliased(["aaa", "aaa"]))