Refactor to hash from multiple ifs

This commit is contained in:
Thayol
2022-03-30 17:54:52 +02:00
parent cbe7ee4897
commit 89b40a65ba

View File

@@ -118,11 +118,7 @@ class PostQueryBuilder
def metatags_match(metatags, relation)
metatags.each do |metatag|
if metatag.negated
metatag.name = "fav" if metatag.name == "ordfav"
metatag.name = "favgroup" if metatag.name == "ordfavgroup"
metatag.name = "pool" if metatag.name == "ordpool"
end
metatag.name = metatags_without_ord[metatag.name] if metatag.negated && metatags_without_ord.key?(metatag.name)
clause = metatag_matches(metatag.name, metatag.value, quoted: metatag.quoted)
clause = clause.negate_relation if metatag.negated
@@ -132,6 +128,14 @@ class PostQueryBuilder
relation
end
def metatags_without_ord
{
"ordfav" => "fav",
"ordfavgroup" => "favgroup",
"ordpool" => "pool",
}
end
def metatag_matches(name, value, quoted: false)
case name
when "id"