Merge pull request #4631 from nonamethanks/fix_ordfav

Return empty search for ordfav of fake user
2020-12-05 12:46:26 -06:00
parent c8a9015e8e 4070354322
commit d5d77e506f
1 changed files with 6 additions and 1 deletions
--- a/app/logical/post_query_builder.rb
+++ b/app/logical/post_query_builder.rb
@@ -398,7 +398,12 @@ class PostQueryBuilder

  def ordfav_matches(username)
    user = User.find_by_name(username)
-    favorites_include(username).joins(:favorites).merge(Favorite.for_user(user.id)).order("favorites.id DESC")
+
+    if user.present?
+      favorites_include(username).joins(:favorites).merge(Favorite.for_user(user.id)).order("favorites.id DESC")
+    else
+      Post.none
+    end
  end

  def note_matches(query)