Albert Yi
0b9c1e1156
Merge pull request #2759 from evazion/fix-dmail-filters
...
Don't filter dmails from moderators; fix dmail filter exploit.
2016-11-14 16:27:17 -08:00
Albert Yi
536ba3c7ee
fixes #2756 : Have @Mentions Use Relative Instead of Absolute Links
2016-11-14 10:15:11 -08:00
evazion
47f663e002
Don't filter dmails from moderators ( fix #2757 ).
2016-11-12 01:11:40 -06:00
evazion
2dadad395b
Add test for setting dmail filters on other people.
2016-11-12 01:10:14 -06:00
Albert Yi
30899b7d3b
Merge pull request #2753 from evazion/feat-autotag-cosplay
...
Autotag character_(cosplay) -> character, cosplay.
2016-11-11 16:48:30 -08:00
Albert Yi
ed6b48b0bc
Merge pull request #2754 from evazion/fix-comment-selfvotes
...
Prevent users from upvoting their own comments.
2016-11-11 16:46:50 -08:00
Albert Yi
eb6746a8a8
additional checks on forum topic visibility
2016-11-07 10:48:04 -08:00
evazion
1047d7c96b
Prevent users from upvoting their own comments.
2016-11-06 01:32:54 -06:00
evazion
f02a31a447
Autotag character_(cosplay) -> character, cosplay.
...
Make e.g. hatsune_miku_(cosplay) automatically add hatsune_miku and cosplay.
Perform autotagging after aliasing so that *_(cosplay) aliases (e.g.
hestia_(dungeon)_(cosplay) -> hestia_(danmachi)_(cosplay)) can take
effect first.
2016-11-04 23:37:28 -05:00
Albert Yi
91793fff82
fixes #2731 : Expunged posts should clear favorite groups
2016-11-01 13:44:36 -07:00
Albert Yi
cb1c694074
fix test
2016-11-01 13:28:31 -07:00
Albert Yi
2dbb869188
keep track of post approvals to prevent approval cycles
2016-10-31 17:51:44 -07:00
evazion
6a9b68022a
Test /forum_posts?search[creator_id]=1.
2016-10-31 17:11:52 -05:00
Albert Yi
a862c5bf03
fixes #2746 : Uploading from touch.pixiv.net broken
2016-10-31 12:22:32 -07:00
evazion
4e9f7391e6
Test private topics don't bump forum.
2016-10-30 18:00:26 -05:00
evazion
88a8c02f4c
Test /forum_posts doesn't list private forum topics.
2016-10-30 18:00:26 -05:00
Albert Yi
597d724832
add api limiter test
2016-10-27 10:48:59 -07:00
Albert Yi
8e87d41a3c
Merge pull request #2739 from evazion/fix-tag-alias
...
Fix "conflicting wikis" message; fix alias/implication approvers in BURs (#2715 )
2016-10-27 10:44:51 -07:00
evazion
8672604ee7
Add upvote:/downvote: editing metatags.
2016-10-26 23:23:47 -05:00
evazion
8b5aac7808
Add locked:{notes,status,rating} editing metatags ( fix #1716 ).
2016-10-26 23:23:09 -05:00
evazion
0dcd7e82be
Test forum posts generated by tag alias approval.
2016-10-26 21:52:19 -05:00
evazion
1e9bcf75de
Test banning artist sets approver of banned_artist implication.
2016-10-26 21:52:19 -05:00
evazion
6dd8ec909d
Set approver of aliases/implications in BURs.
...
Previously only the BUR's approver was set when a BUR was approved. Set
the approver for each alias/implication in the BUR as well.
Additionally:
* Refactor `approve!` to take a user instead of just a user id.
* Be mass-assignment permissions aware when setting approver_id.
2016-10-26 21:52:19 -05:00
evazion
1e8a68a56b
Test that approving BUR sets approver of aliases/implications.
2016-10-26 21:52:18 -05:00
Albert Yi
24d44dd4f8
fix tests, better error handling in pixiv ugoira converter
2016-10-25 16:20:47 -07:00
Albert Yi
589df5f301
implements #2658 : private forum topics
2016-10-24 16:56:18 -07:00
Albert Yi
f158e10c37
Merge pull request #2734 from evazion/fix-negated-aliases
...
Resolve aliases when removing negated tags (fix #2730 )
2016-10-24 12:21:21 -07:00
Albert Yi
95c3f5342a
Merge pull request #2733 from evazion/fix-tag-normalization
...
Fix metatag editing so that rating:s obeys rate locks, source:blah updates pixiv id
2016-10-24 12:18:41 -07:00
Albert Yi
e8336afd81
fixes #2718 : Twitter artist finding should not be case sensitive
2016-10-24 12:18:44 -07:00
evazion
c6294d5dfd
Resolve aliases when removing negated tags ( fix #2730 ).
2016-10-21 23:39:35 -05:00
evazion
52491f4486
Fix @artist.ban! test case.
...
Must use an admin in this test now because admin privileges are needed
to create the `banned_artist` tag implication.
(fixes regression in 7e3284c )
2016-10-21 19:59:02 -05:00
evazion
8b46726166
Fix tests for before_validation :normalize_tags.
...
`update_attribute` doesn't trigger `before_validation` callbacks, which
is where metatag processing happens. `update` or `update_attributes`
must be used instead.
AFAIK the test suite is the only place where `post.update_attribute(:tag_string => "stuff")`
is used, the actual code doesn't use it.
2016-10-21 19:59:02 -05:00
evazion
0b7cd71d42
Add some tests for tagging posts with metatags.
...
Exercise a few bugs:
* rating:safe should obey on rating locks.
* source:blah should update the pixiv id.
* source:" foo bar baz " should trim leading/trailing whitespace.
The other tests are for metatags that work but didn't have tests.
2016-10-21 19:59:01 -05:00
Albert Yi
080eecb6b9
Merge pull request #2729 from evazion/fix-notes-mass-assignment
...
Fix vuln allowing users to move notes between posts.
2016-10-20 16:22:43 -07:00
evazion
d2f3027294
Add test for moving notes between posts.
2016-10-19 22:54:39 -05:00
evazion
88248e7ec7
Add tests for reverting rating-locked posts.
2016-10-19 20:06:43 -05:00
evazion
d2a0b089f4
Add test for setting invalid ratings.
2016-10-19 20:06:43 -05:00
Albert Yi
fb1cf5edbc
Merge pull request #2726 from evazion/feat-log-tag-aliases+implications
...
Log tag aliases+implications
2016-10-19 10:07:08 -07:00
Albert Yi
2a5343b8cf
add more intelligent js for artist forms
2016-10-18 14:56:40 -07:00
Albert Yi
2424f24fcd
return 429 for too many requests instead of 421
2016-10-18 13:33:04 -07:00
evazion
5743166e25
Add a test case for implication requests.
2016-10-18 05:22:44 -05:00
evazion
5e75dcecea
Add test cases for anon/banned/member voting.
2016-10-14 04:47:51 +00:00
Albert Yi
eaa0426c36
Merge pull request #2714 from evazion/fix-2704
...
Fix mass assignment vuln to tag alias/implication status (partial fix for #2704 ).
2016-10-11 17:48:26 -07:00
evazion
101771adb8
Aliases/implications: Add tests for status and foreign keys.
2016-10-11 08:19:52 +00:00
evazion
80895ef46e
Add tests for reverting to foreign versions.
2016-10-11 06:57:05 +00:00
Albert Yi
23ad02fa9c
fix super voter test
2016-10-10 18:14:49 -07:00
Albert Yi
d5f02abf8c
fix saved search test
2016-10-10 17:29:49 -07:00
evazion
3838167dc0
Post#unvote!: Return correct score ( fixes #2709 ).
...
vote.destroy sets the score in the database but not on the in-memory
post. So just reload the post from the db to get the updated score,
don't duplicate the logic of setting it again.
2016-10-08 09:07:41 +00:00
evazion
cb1e1d3a94
Prevent commenting on nonexistent posts ( #2704 ).
2016-10-06 09:39:57 +00:00
evazion
8c8f4a6a8f
Fix mass assignment vuln in comment update action ( #2704 ).
...
Prevents mass assignment of `post_id`, `do_not_bump_post`, and
`is_deleted`.
2016-10-06 09:39:57 +00:00