Commit Graph

856 Commits

Author SHA1 Message Date
evazion
6dd8ec909d Set approver of aliases/implications in BURs.
Previously only the BUR's approver was set when a BUR was approved. Set
the approver for each alias/implication in the BUR as well.

Additionally:

* Refactor `approve!` to take a user instead of just a user id.
* Be mass-assignment permissions aware when setting approver_id.
2016-10-26 21:52:19 -05:00
evazion
1e8a68a56b Test that approving BUR sets approver of aliases/implications. 2016-10-26 21:52:18 -05:00
Albert Yi
24d44dd4f8 fix tests, better error handling in pixiv ugoira converter 2016-10-25 16:20:47 -07:00
Albert Yi
589df5f301 implements #2658: private forum topics 2016-10-24 16:56:18 -07:00
Albert Yi
f158e10c37 Merge pull request #2734 from evazion/fix-negated-aliases
Resolve aliases when removing negated tags (fix #2730)
2016-10-24 12:21:21 -07:00
Albert Yi
95c3f5342a Merge pull request #2733 from evazion/fix-tag-normalization
Fix metatag editing so that rating:s obeys rate locks, source:blah updates pixiv id
2016-10-24 12:18:41 -07:00
Albert Yi
e8336afd81 fixes #2718: Twitter artist finding should not be case sensitive 2016-10-24 12:18:44 -07:00
evazion
c6294d5dfd Resolve aliases when removing negated tags (fix #2730). 2016-10-21 23:39:35 -05:00
evazion
52491f4486 Fix @artist.ban! test case.
Must use an admin in this test now because admin privileges are needed
to create the `banned_artist` tag implication.

(fixes regression in 7e3284c)
2016-10-21 19:59:02 -05:00
evazion
8b46726166 Fix tests for before_validation :normalize_tags.
`update_attribute` doesn't trigger `before_validation` callbacks, which
is where metatag processing happens. `update` or `update_attributes`
must be used instead.

AFAIK the test suite is the only place where `post.update_attribute(:tag_string => "stuff")`
is used, the actual code doesn't use it.
2016-10-21 19:59:02 -05:00
evazion
0b7cd71d42 Add some tests for tagging posts with metatags.
Exercise a few bugs:

* rating:safe should obey on rating locks.
* source:blah should update the pixiv id.
* source:"  foo bar baz  " should trim leading/trailing whitespace.

The other tests are for metatags that work but didn't have tests.
2016-10-21 19:59:01 -05:00
Albert Yi
080eecb6b9 Merge pull request #2729 from evazion/fix-notes-mass-assignment
Fix vuln allowing users to move notes between posts.
2016-10-20 16:22:43 -07:00
evazion
d2f3027294 Add test for moving notes between posts. 2016-10-19 22:54:39 -05:00
evazion
88248e7ec7 Add tests for reverting rating-locked posts. 2016-10-19 20:06:43 -05:00
evazion
d2a0b089f4 Add test for setting invalid ratings. 2016-10-19 20:06:43 -05:00
Albert Yi
fb1cf5edbc Merge pull request #2726 from evazion/feat-log-tag-aliases+implications
Log tag aliases+implications
2016-10-19 10:07:08 -07:00
Albert Yi
2a5343b8cf add more intelligent js for artist forms 2016-10-18 14:56:40 -07:00
Albert Yi
2424f24fcd return 429 for too many requests instead of 421 2016-10-18 13:33:04 -07:00
evazion
5743166e25 Add a test case for implication requests. 2016-10-18 05:22:44 -05:00
evazion
5e75dcecea Add test cases for anon/banned/member voting. 2016-10-14 04:47:51 +00:00
Albert Yi
eaa0426c36 Merge pull request #2714 from evazion/fix-2704
Fix mass assignment vuln to tag alias/implication status (partial fix for #2704).
2016-10-11 17:48:26 -07:00
evazion
101771adb8 Aliases/implications: Add tests for status and foreign keys. 2016-10-11 08:19:52 +00:00
evazion
80895ef46e Add tests for reverting to foreign versions. 2016-10-11 06:57:05 +00:00
Albert Yi
23ad02fa9c fix super voter test 2016-10-10 18:14:49 -07:00
Albert Yi
d5f02abf8c fix saved search test 2016-10-10 17:29:49 -07:00
evazion
3838167dc0 Post#unvote!: Return correct score (fixes #2709).
vote.destroy sets the score in the database but not on the in-memory
post. So just reload the post from the db to get the updated score,
don't duplicate the logic of setting it again.
2016-10-08 09:07:41 +00:00
evazion
cb1e1d3a94 Prevent commenting on nonexistent posts (#2704). 2016-10-06 09:39:57 +00:00
evazion
8c8f4a6a8f Fix mass assignment vuln in comment update action (#2704).
Prevents mass assignment of `post_id`, `do_not_bump_post`, and
`is_deleted`.
2016-10-06 09:39:57 +00:00
evazion
ab5fd48280 Prevent mass assignment to Post#last_noted_at (#2704). 2016-10-06 09:39:57 +00:00
evazion
b6af41e0f8 Add test cases for twitter artist finder. 2016-10-05 08:13:27 +00:00
evazion
f4f85bd0d8 Add tests for setting pixiv_id on posts. 2016-10-03 02:29:41 +00:00
r888888888
5b48d272f2 add basic user revert functionality 2016-09-28 11:38:34 -07:00
r888888888
fc7afd44ea refactor source pixiv test
refactor pixiv download tests
refactor upload test
refactor nico seiga test
refactor twitter tests
2016-09-28 11:25:29 -07:00
r888888888
4fa2741ed2 include whitecube source/rewrite strategies 2016-09-28 11:24:54 -07:00
Type-kun
9147a1b178 Update APNGInspector class and add tests (fixes #2237) 2016-09-18 14:13:11 +05:00
r888888888
ab6b5e49fe addresses #2674: aliases+updates should migrate saved searches 2016-09-14 18:48:45 -07:00
r888888888
f720641942 fix tir controller test 2016-09-12 18:05:55 -07:00
r888888888
fd38539b41 fix twitter upload tests 2016-09-12 18:02:59 -07:00
r888888888
97c89d06d8 fix pool controller test 2016-09-12 17:38:55 -07:00
r888888888
b0e94f59fb remove dtext perf test 2016-09-12 17:22:17 -07:00
Type-kun
a7fee8815b Fix test for dtext header IDs 2016-09-10 10:41:27 +05:00
Type-kun
8c04a9d390 Fix #2598 for old parser 2016-09-06 01:06:29 +05:00
r888888888
917e42ed29 when merging post versions, delete old version rather than updating it 2016-06-29 14:47:32 -07:00
r888888888
4fea400b79 fixes #2610: Strip image metadata when creating thumbnails and samples 2016-06-15 11:38:35 -07:00
r888888888
505f3f7c03 fixes #2609: BUR is impossible to approve 2016-06-15 11:17:19 -07:00
r888888888
45e5ea817a update tests 2016-06-12 15:12:30 -07:00
r888888888
58aa5c6d66 fix tests 2016-05-28 14:08:44 -07:00
r888888888
110569708e fix tests 2016-05-26 13:17:18 -07:00
r888888888
30415d9e1e add approver field to aliases/implications 2016-05-26 13:01:44 -07:00
r888888888
2a87aad34e implement super voters 2016-02-22 14:11:25 -08:00