Commit Graph

6077 Commits

Author SHA1 Message Date
evazion
76c90cc0e4 Remove unused Pool methods: create_anonymous/options/id_to_name (#3206)
* Pool.id_to_name: never used.
* Pool.create_anonymous: never used.
* Pool.options: unused since e7aff87.
2017-07-09 14:32:17 -05:00
evazion
af35c82d96 Remove unused Artist#legacy_api_hash method (#3206).
Added in 0e0d83c7 but never used. app/views/legacy/artists.{json,xml}.erb
is what *would* use this, but neither does.
2017-07-09 13:49:20 -05:00
Albert Yi
a860bec0a7 Merge pull request #3207 from evazion/feat-note-links
Fix #3205: Add ability to link to individual notes
2017-07-07 18:59:39 -07:00
Albert Yi
1cc9abc2db Merge pull request #3204 from evazion/fix-3203
Fix #3203: Overly restrictive permissions
2017-07-07 18:59:13 -07:00
evazion
e875f2973a /notes, /note_versions: link directly to note within post.
Also adds a "»" link, linking to the note's history.
2017-07-07 16:39:10 -05:00
evazion
c13000a41e notes: show note id in note edit dialog title. 2017-07-07 16:09:24 -05:00
evazion
ab0b4b4c67 notes: highlight notes linked via /posts/456#note-123. 2017-07-07 16:09:24 -05:00
evazion
c2e62b77fa notes: move js initialization into initialize_all function. 2017-07-07 16:09:24 -05:00
evazion
0bc55bec74 notes: redirect /notes/123 to /posts/456#note-123. 2017-07-07 16:09:23 -05:00
evazion
df33901938 PostQueryBuilder: remove unused has_constraints attr (#3206).
This was previously used to prevent searches that contained only negated
tags. No longer used.
2017-07-07 16:08:02 -05:00
evazion
e3922fb525 flags/appeals controllers: remove unused check_privilege method (#3206). 2017-07-07 15:47:57 -05:00
evazion
24b2f2bf52 /user/dmail_filter: make available to banned users.
`ensure_ownership` handles the privilege check here.
2017-07-07 15:41:09 -05:00
evazion
d092b870ad /users/:id/api_keys: make available to banned users.
`check_privilege` already handles the privilege check here.
2017-07-07 15:40:40 -05:00
evazion
0c79d2f09e Removed unused controllers actions / routes (#3206). 2017-07-07 15:38:06 -05:00
evazion
d786fc7a55 Removed unused UploadTagsReport controller (#3206).
This was moved to ReportsController#upload_tags as of 7f22baa.
2017-07-07 14:46:04 -05:00
evazion
9e39d292a6 Fix /bulk_update_requests/1234.json. 2017-07-07 14:33:16 -05:00
evazion
400127c090 /saved_searches: make available to banned users. 2017-07-06 19:26:23 -05:00
evazion
f5209c7fb9 /favorites: make available to anonymous users. 2017-07-06 19:22:57 -05:00
evazion
e6a5d1e9e8 /bulk_update_requests: make available to anonymous users. 2017-07-06 19:20:38 -05:00
evazion
0ed2dafdce /iqdb_queries: make available to anonymous users. 2017-07-06 19:18:45 -05:00
evazion
216243a354 /forum_posts/search: make available to anonymous users. 2017-07-06 19:18:15 -05:00
evazion
3a8cae4de1 /notes/search: make available to anonymous users. 2017-07-06 19:16:43 -05:00
evazion
d8f8983f94 /uploads/report_tags: make available to anonymous users. 2017-07-06 19:16:03 -05:00
evazion
ecf5040160 /uploads: make available to anonymous users. 2017-07-06 19:14:17 -05:00
evazion
bef02e0ac1 /wiki_pages/search: make available to anonymous users. 2017-07-06 19:12:17 -05:00
evazion
ef1db967f7 /dmails: allow banned users to read/delete dmails. 2017-07-06 18:39:42 -05:00
evazion
cda1ee3d88 /users: allow banned users to edit account settings.
The member_only check prevents banned users from editing their account
settings. This isn't needed since check_privilege handles the privilege check.
2017-07-06 18:39:42 -05:00
evazion
cc54c16fac /artists/show_or_new: make public; add "artist doesn't exist" page.
* Fix access denied error when anonymous users open /artists/show_or_new.

* When the artist doesn't exist, take user to "artist doesn't exist"
  page instead of redirecting to /artists/new.
2017-07-06 18:37:13 -05:00
evazion
e5598be20e Factor out artists/show view into artists/_show layout. 2017-07-06 18:15:12 -05:00
evazion
68bf355542 upload tags report: add blacklist controls (#3121). 2017-07-05 19:40:48 -05:00
Albert Yi
80fdafad45 Merge pull request #3201 from evazion/fix-transitive-implications
Fix #3200: Disallow creation of superfluous implications
2017-07-05 11:50:51 -07:00
Albert Yi
5d40f5ad66 Merge pull request #3198 from evazion/feat-tumblr-dtextify-artcomm
Tumblr: convert artist commentaries from HTML to DText (#3184)
2017-07-05 11:31:30 -07:00
evazion
aac1463fbf implications: count 'queued' implications as active.
Bug: implications that were approved but that were still in the 'queued'
state were not seen as active yet, which led to the transitivity
validation passing because it didn't include queued implications.
2017-07-05 00:22:27 -05:00
evazion
542c673221 Fix #3200: Disallow creation of superfluous implications.
Disallow transitive implications. If a -> b -> c already exists, don't
allow a -> c.

Caveat: if b -> c already exists, and we make a BUR for a -> b and a -> c,
the BUR validates even though a -> c is redundant. It only fails
when the BUR is approved.
2017-07-05 00:22:16 -05:00
evazion
cda35494a4 Disable blacklists on pages without blacklist controls. (#3183) 2017-07-03 15:10:36 -05:00
evazion
c3ac4f3329 Fix #3197 - Post Replacement comment: use Replacement URL instead of Final Source
Record the URL of the image that was actually downloaded as the replacement URL.
2017-07-02 21:00:26 -05:00
evazion
5a2745ee71 Fix post replacement controller test.
Broken in 27aa9fe. Delayed jobs have to be enabled when creating a
replacement, otherwise replacement will try to immediately delete the
existing files, which fails because they're still in use.
2017-07-01 13:37:32 -05:00
evazion
0390039621 Fix expunging posts from S3 (fixup 4c4ef5c / #3180). 2017-07-01 12:30:59 -05:00
evazion
f8ed7d4357 tests: fix HTTP requests failing due to webmock (#3039).
Fixes failures in source tests caused by Webmock disabling non-stubbed
HTTP requests by default.

https://github.com/bblimke/webmock#real-requests-to-network-can-be-allowed-or-disabled
2017-07-01 12:22:36 -05:00
evazion
1c06ae9f81 atom feeds: fix deprecation warnings in *_path helpers.
DEPRECATION WARNING: You are calling a `*_path` helper with the
`only_path` option explicitly set to `false`. This option will stop
working on path helpers in Rails 5. Use the corresponding `*_url` helper
instead.
2017-07-01 11:45:28 -05:00
evazion
71f84b10af tumblr: convert commentary to dtext.
* Convert Tumblr commentary to DText.
* Strip extraneous whitespace in links and blockquotes.
* Add newlines after block elements to ensure they're separated from
  subsequent blocks.
2017-07-01 11:15:48 -05:00
evazion
b880b07387 sources: factor out html-to-dtext code to DText.from_html. 2017-07-01 11:15:48 -05:00
r888888888
d7690d24b0 fixes #3039 2017-06-29 16:05:01 -07:00
r888888888
c4503e9971 Revert "#2234 comment out post previews"
This reverts commit 4281d1a48f.
2017-06-29 13:15:02 -07:00
r888888888
d4c89bccfc potential fix for #3189 2017-06-29 13:09:33 -07:00
r888888888
361e98edee fix for flagger_id_neg search case where nothing is matched 2017-06-29 13:03:36 -07:00
r888888888
d2c8e9ec6a add without timeout block for supervoter calculation 2017-06-27 18:06:57 -07:00
r888888888
4c4ef5cc5b fixes #3180 2017-06-27 15:12:12 -07:00
r888888888
610e2bdedd fixes #3191 2017-06-27 14:48:55 -07:00
r888888888
a9f15cd862 remove unused pixiv test script 2017-06-27 14:48:55 -07:00