evazion
92e4635af8
ip addresses: fix reference to CurrentUser inside visible.
2020-03-21 23:06:42 -05:00
evazion
94aff2c777
moderation reports: pass CurrentUser to visible explicitly.
...
This is for consistency with how `visible` works in other models.
2020-03-21 23:06:42 -05:00
evazion
2445e8b82f
favorites: convert user.hide_favorites? to pundit.
2020-03-21 23:06:42 -05:00
evazion
5bc82bf07b
users: remove user is not ip banned validation.
...
This is handled on the controller level now.
2020-03-21 23:06:42 -05:00
evazion
b21e1d219c
users: remove as_admin and as_current methods.
2020-03-21 23:06:42 -05:00
evazion
94d78287eb
bulk update request pruner: fix forum posts reference.
2020-03-21 23:06:42 -05:00
evazion
e4d63eb0da
post versions: fix index action when no versions exist.
...
Fix a nil dereference error during testing when no post versions exist.
2020-03-21 23:06:42 -05:00
evazion
41ab3c9f63
post versions: fix undo action.
2020-03-21 23:06:42 -05:00
evazion
ca27929249
tests: add more posts/show tests.
2020-03-21 23:06:42 -05:00
evazion
3656063a6b
tests: fix unit tests.
...
* Move old post archive tests to post version tests.
* Fix pool tests that assumed that multiple edits by the same user
weren't merged.
* Fix references to `is_active` and `notes` on artist model.
2020-03-21 21:07:35 -05:00
evazion
94ae10b1a6
tests: fix post and pool version tests helpers.
...
* Fix the pool version SQS service to always be mocked before every
test. Before we had to manually set it up before every test dealing
with pool versions.
* Fix it so that we reconnect to the post/pool version databases before
every test. Before using $ARCHIVE_DATABASE_URL to set the database url
failed because environment variables weren't loaded by dotenv yet when
connections were first established.
2020-03-21 19:28:10 -05:00
evazion
3cb2c10be8
Merge pull request #4349 from danbooru/refactor-pundit
...
Refactor authorization logic to use Pundit
2020-03-20 18:47:33 -05:00
evazion
d775c625bb
application controller: remove role_only! methods.
2020-03-20 18:03:50 -05:00
evazion
79e7b9308e
pundit: convert misc privilege checks in views to pundit.
2020-03-20 18:03:50 -05:00
evazion
7f742242e4
pundit: convert uploads to pundit.
2020-03-20 18:03:01 -05:00
evazion
d51b0dfe17
pundit: convert moderator/post/posts to pundit.
2020-03-20 18:03:01 -05:00
evazion
1344d4c161
pundit: convert moderator/dashboard to pundit.
...
Make it visible to everyone since there's no non-public information here.
2020-03-20 18:03:01 -05:00
evazion
a5418abb31
pundit: convert posts to pundit.
2020-03-20 18:03:01 -05:00
evazion
dd39913e55
pundit: convert post replacements to pundit.
2020-03-20 18:03:01 -05:00
evazion
3bb3c0b990
pundit: convert saved searches to pundit.
2020-03-20 18:03:01 -05:00
evazion
415d9591c5
pundit: convert post votes to pundit.
...
Side effects:
* The data-current-user-is-voter <body> attribute has been removed.
* {{upvote:self}} no longer works. {{upvote:<name>}} should be used instead.
2020-03-20 18:03:01 -05:00
evazion
33d81d0d1b
pundit: convert post flags to pundit.
2020-03-20 18:03:01 -05:00
evazion
ffae64f127
pundit: convert post versions to pundit.
2020-03-20 18:03:01 -05:00
evazion
ba0a5dda8a
pundit: convert post disapprovals to pundit.
2020-03-20 18:03:01 -05:00
evazion
84c654464d
pundit: convert post approvals to pundit.
2020-03-20 18:03:01 -05:00
evazion
cbee23f9ad
pundit: convert post appeals to pundit.
2020-03-20 18:03:01 -05:00
evazion
ab5432d149
pundit: convert pools to pundit.
2020-03-20 18:03:01 -05:00
evazion
83eae1bf11
pundit: convert passwords to pundit.
2020-03-20 18:03:01 -05:00
evazion
62835ac9fc
pundit: convert notes to pundit.
2020-03-20 18:03:01 -05:00
evazion
2c4c29b81a
pundit: convert favorite groups to pundit.
2020-03-20 18:03:01 -05:00
evazion
50fa674a3e
pundit: convert emails to pundit.
2020-03-20 18:03:01 -05:00
evazion
a440c56ed8
pundit: convert comment votes to pundit.
2020-03-20 18:03:01 -05:00
evazion
ce1133dd69
pundit: convert artist commentaries to pundit.
2020-03-20 18:03:01 -05:00
evazion
3d83c3154e
pundit: convert forum topic visits to pundit.
2020-03-20 18:03:01 -05:00
evazion
f1f489c40b
pundit: convert favorites to pundit.
2020-03-20 18:03:01 -05:00
evazion
cc2b4abd09
pundit: convert forum post votes to pundit.
2020-03-20 18:03:01 -05:00
evazion
be59e85d25
pundit: convert ip addresses to pundit.
2020-03-20 18:03:01 -05:00
evazion
92aeb8728f
pundit: convert ip bans to pundit.
2020-03-20 18:03:01 -05:00
evazion
9242bf522b
pundit: convert moderation reports to pundit.
2020-03-20 18:03:01 -05:00
evazion
480f39c34a
pundit: convert dmails to pundit.
2020-03-20 18:03:01 -05:00
evazion
15ba2f6cd7
tests: fix email delivery tests.
...
Setting deliver_later_queue_name inside config/application.rb broke
tests because assert_enqueued_email_with assumes that the deliver_later
queue is called `mailers`.
2020-03-20 18:03:00 -05:00
evazion
19817a6f85
pundit: convert modqueue to pundit.
2020-03-20 18:03:00 -05:00
evazion
3d72e62c77
pundit: convert bans to pundit.
2020-03-20 18:03:00 -05:00
evazion
ff1d71af2e
pundit: convert artists to pundit.
2020-03-20 18:03:00 -05:00
evazion
79a365abe0
pundit: convert bulk update requests to pundit.
2020-03-20 18:03:00 -05:00
evazion
b83c612246
pundit: convert delayed jobs to pundit.
2020-03-20 18:03:00 -05:00
evazion
4a36b99614
pundit: convert tag aliases / implications to pundit.
2020-03-20 18:03:00 -05:00
evazion
4bb036aff1
pundit: convert tags to pundit.
2020-03-20 18:03:00 -05:00
evazion
4cd0b2cbfe
pundit: convert user feedbacks to pundit.
...
Allow users to delete feedbacks they've given to other users, not just
mods.
2020-03-20 18:03:00 -05:00
evazion
565a6572a7
pundit: convert user name change requests to pundit.
...
Fix discrepancy between index action and show action. The index
action allowed members to see name changes for undeleted users, but the
show action didn't.
2020-03-20 18:03:00 -05:00
