Commit Graph

6723 Commits

Author SHA1 Message Date
Albert Yi
ceecc62aa8 Merge pull request #3557 from evazion/fix-autocomplete-consistency
Fix inconsistencies in autocomplete behavior
2018-02-21 14:51:50 -08:00
evazion
c482175050 Fix #3558: Autocomplete: negated metatags aren't completed.
Fix Danbooru.Autocomplete.parse_query to strip prefixes off of
metatags.
2018-02-19 23:57:46 -06:00
evazion
d8e195d168 autocomplete: unify autocomplete options.
Use a single set of default options so that autocomplete behaves
the same way everywhere.
2018-02-18 19:22:46 -06:00
evazion
4754daf594 autocomplete: unify menu item rendering.
* Use `Danbooru.Autocomplete.render_item` for all menu item rendering.
  Fixes usernames not being colorized when completing mentions, and post
  counts not being shown when completing pools on the /pools page.

* Make the /pools page autocomplete pool names the same way that the
  pool:<name> metatag does. Previously autocomplete on the /pools page
  listed most recently updated pools first; now it lists largest pools first.
2018-02-18 19:22:46 -06:00
evazion
962842815d autocomplete: move artist/pool/wiki autocompletion to autocomplete.js.
* Move all autocomplete code to autocomplete.js.

* Mark autocompleted fields with `data-autocomplete="<type>"` attributes,
  instead of hardcoding input field IDs in the javascript.
2018-02-18 19:22:17 -06:00
evazion
a058a77c07 ApplicationHelper#search_field: accept html attributes on <input> field.
Rewrite `search_field` to allow setting `data-*` attributes on the <input> field.
2018-02-18 18:34:18 -06:00
Albert Yi
9204cd825e Merge pull request #3550 from evazion/fix-3548
#3548: Upgrade to jquery-1.12.4
2018-02-15 20:21:04 -08:00
evazion
9aa0af82ba Upgrade to jquery-1.12.4; add jquery-migrate plugin (#3548). 2018-02-15 21:38:16 -06:00
Albert Yi
26b260f1c8 Merge pull request #3549 from evazion/fix-autocomplete-autofocus
Autocomplete: Fix issues with Enter key
2018-02-15 11:19:32 -08:00
evazion
0e259bd4f6 autocomplete: fix issues with Enter key.
* Disable autoFocus. This means that the first item in the autocomplete
  menu isn't automatically selected.

* Add Tab keybinding, to make the Tab key work as normal with autoFocus disabled.

* Fix the Enter key to 1) insert the selected tag when inside the
  autocomplete menu, and 2) submit the search as normal when not inside
  the autocomplete menu.
2018-02-14 22:09:14 -06:00
evazion
b877c037b2 autocomplete: factor out insert_completion function. 2018-02-14 20:23:37 -06:00
Albert Yi
8d3e3dd523 Merge pull request #3546 from evazion/fix-3545
Fix #3545: Autocomplete: enter key should submit on exact match
2018-02-13 10:30:04 -08:00
evazion
f0754c21f5 autocomplete: make enter key submit on exact match. 2018-02-13 10:52:43 -06:00
evazion
ab86c2049f autocomplete: factor out parse_query function. 2018-02-13 10:36:20 -06:00
Albert Yi
4e10913e31 Merge pull request #3544 from BrokenEagle/fix-autocomplete-nosource
Clear results when a non-autocomplete metatag is used
2018-02-13 00:30:31 -08:00
BrokenEagle
30401591fb Set blank results when a non-autocomplete metatag is used
-Otherwise, the last valid autocomplete result will remain
--Causes incorrect results on Tab/Enter completion
-This clears the autocomplete results instead
2018-02-12 17:20:12 -08:00
evazion
e8ab5cdc4c Fix pool version ordering.
Pool version IDs aren't in the right order; order by updated_at instead.
2018-02-08 16:53:02 -06:00
Albert Yi
27f2b9d365 Merge pull request #3540 from r888888888/revert-3529-most-valued
Revert "implement post keepers"
2018-02-07 12:29:06 -08:00
Albert Yi
b9fcfe0442 Revert "implement post keepers" 2018-02-07 12:28:56 -08:00
Albert Yi
2e62916832 Merge pull request #3529 from r888888888/most-valued
implement post keepers
2018-02-07 12:10:38 -08:00
Albert Yi
a6a2c7a3a1 Merge pull request #3538 from evazion/fix-3532
Fix #3532: Make Enter key accept current tag during autocomplete.
2018-02-07 12:10:24 -08:00
evazion
cf27de2ec9 Fix #3532: Make Enter key accept current tag during autocomplete.
Previously we patched the jqueryui-autocomplete library in order to
customize how the Tab and Enter keys behaved. Specifically, we wanted to
prevent the Tab key from moving the focus out of the tag input box, and
we wanted to prevent the Enter key from submitting the page when editing tags.

These things can achieved without patching the library by using
`event.preventDefault` and `event.stopImmediatePropagation` to prevent
other event handlers from running after these keys trigger the
`autocompleteselect` event.
2018-02-06 19:11:01 -06:00
Albert Yi
b03c8084a5 Merge pull request #3536 from BrokenEagle/fix-resize-with-user-setting
Fix the auto resize in desktop mode (ref: a95af95e)
2018-02-05 15:11:26 -08:00
r888888888
ba6e3f4a0e gracefully handle bad connection errors to replica db ref #3212 2018-02-05 15:05:21 -08:00
r888888888
308e3670df gracefully handle unavailable pg connection errors 2018-02-05 12:38:01 -08:00
BrokenEagle
31114b716a Fix the auto resize in desktop mode (ref: a95af95e) 2018-02-05 10:20:24 -08:00
evazion
f2a7d3c41a /janitor_trials, /ip_bans: fix default ordering. 2018-02-04 16:48:35 -06:00
evazion
dac095f318 /user_feedbacks: change default order to created_at.
Order by created_at instead of by id because old feedbacks aren't in id order.
2018-02-04 16:43:00 -06:00
r888888888
d10c6a3af7 display uploader for mods 2018-02-01 17:10:09 -08:00
r888888888
da2864e233 change keeper name to tagger 2018-02-01 17:07:30 -08:00
r888888888
e0ec9ed518 fix ordering of forum posts in topics 2018-02-01 16:35:47 -08:00
Albert Yi
bd58a5be10 Merge pull request #3530 from evazion/fix-3528
Fix #3527: Bookmarklet timeouts for Members.
2018-02-01 16:03:17 -08:00
evazion
d4298ea493 Fix #3527: Bookmarklet timeouts for Members. 2018-02-01 17:35:20 -06:00
r888888888
32cc508edb hide uploader information on posts/show page, add keeper information 2018-02-01 14:38:03 -08:00
r888888888
146b27f4cf update rbenv version 2018-01-30 12:05:38 -08:00
r888888888
2c4a0cd79d set rbenv path for staging 2018-01-30 12:03:03 -08:00
Albert Yi
a114af107f Merge pull request #3526 from BrokenEagle/fix-mod-actions
Fix mod actions
2018-01-30 11:40:54 -08:00
BrokenEagle
3933c273c4 Add mod action for move favorites 2018-01-30 11:27:28 -08:00
BrokenEagle
92f7bb46a2 Add missing mod action category 2018-01-30 11:27:24 -08:00
r888888888
f82d6fa686 fixes #3512 2018-01-30 11:04:50 -08:00
r888888888
cee3c5522b update dtext gem 2018-01-30 10:54:11 -08:00
Albert Yi
47bd812811 Merge pull request #3525 from BrokenEagle/fix-index-default-order
Fix index default order
2018-01-29 13:11:24 -08:00
BrokenEagle
d829ab3a00 Move all order logic to models
- Have a default order for each model
-- The overall default is ID DESC
- Allow for custom orderings
-- When comma-separated IDs are used
2018-01-29 11:42:53 -08:00
evazion
5ea61c6921 /bans: fix undefined ordering when no params are passed.
Fixes the /bans listing being ordered randomly by default.
2018-01-28 15:38:12 -06:00
evazion
100c1d2828 Fix #3523: Feedback notification dmails should include the text of the feedback. 2018-01-28 14:32:38 -06:00
evazion
64186c004f Add pbs.twimg.com to artist finder blacklist.
ref: https://danbooru.donmai.us/forum_topics/14938.
2018-01-26 18:30:18 -06:00
evazion
f8a5620768 Partial fix for #3514: Handle https://twitter.com/i/web/status/:id URL. 2018-01-23 23:07:21 -06:00
r888888888
f83480cc8a hard core path to rbenv root 2018-01-22 18:04:55 -08:00
Albert Yi
1afce1c88e Merge pull request #3511 from evazion/fix-update-gems
Upgrade gems
2018-01-22 12:55:55 -08:00
evazion
2833239fa0 Fix #3513: Missing rating error causes weird behavior in tag list on upload page.
Fix bug in the double submit prevention from #2789. Rather than
unbinding the enter key on submit, have the enter key click the submit
button instead. This avoids form submission when the submit button is disabled.
2018-01-21 11:55:24 -06:00