abce4d2551
Fail loudly if we forget to whitelist a param instead of silently ignoring it. misc models: convert to strong params. artist commentaries: convert to strong params. * Disallow changing or setting post_id to a nonexistent post. artists: convert to strong params. * Disallow setting `is_banned` in create/update actions. Changing it this way instead of with the ban/unban actions would leave the artist in a partially banned state. bans: convert to strong params. * Disallow changing the user_id after the ban has been created. comments: convert to strong params. favorite groups: convert to strong params. news updates: convert to strong params. post appeals: convert to strong params. post flags: convert to strong params. * Disallow users from setting the `is_deleted` / `is_resolved` flags. ip bans: convert to strong params. user feedbacks: convert to strong params. * Disallow users from setting `disable_dmail_notification` when creating feedbacks. * Disallow changing the user_id after the feedback has been created. notes: convert to strong params. wiki pages: convert to strong params. * Also fix non-Builders being able to delete wiki pages. saved searches: convert to strong params. pools: convert to strong params. * Disallow setting `post_count` or `is_deleted` in create/update actions. janitor trials: convert to strong params. post disapprovals: convert to strong params. * Factor out quick-mod bar to shared partial. * Fix quick-mod bar to use `Post#is_approvable?` to determine visibility of Approve button. dmail filters: convert to strong params. password resets: convert to strong params. user name change requests: convert to strong params. posts: convert to strong params. users: convert to strong params. * Disallow setting password_hash, last_logged_in_at, last_forum_read_at, has_mail, and dmail_filter_attributes[user_id]. * Remove initialize_default_image_size (dead code). uploads: convert to strong params. * Remove `initialize_status` because status already defaults to pending in the database. tag aliases/implications: convert to strong params. tags: convert to strong params. forum posts: convert to strong params. * Disallow changing the topic_id after creating the post. * Disallow setting is_deleted (destroy/undelete actions should be used instead). * Remove is_sticky / is_locked (nonexistent attributes). forum topics: convert to strong params. * merges https://github.com/evazion/danbooru/tree/wip-rails-5.1 * lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4) * switch to factorybot and change all references Co-authored-by: r888888888 <r888888888@gmail.com> Co-authored-by: evazion <noizave@gmail.com> add diffs
97 lines
2.5 KiB
Ruby
97 lines
2.5 KiB
Ruby
class PoolsController < ApplicationController
|
|
respond_to :html, :xml, :json, :js
|
|
before_action :member_only, :except => [:index, :show, :gallery]
|
|
before_action :builder_only, :only => [:destroy]
|
|
|
|
def new
|
|
@pool = Pool.new
|
|
respond_with(@pool)
|
|
end
|
|
|
|
def edit
|
|
@pool = Pool.find(params[:id])
|
|
if @pool.is_deleted && !@pool.deletable_by?(CurrentUser.user)
|
|
raise User::PrivilegeError
|
|
end
|
|
respond_with(@pool)
|
|
end
|
|
|
|
def index
|
|
@pools = Pool.search(search_params).paginate(params[:page], :limit => params[:limit], :search_count => params[:search])
|
|
respond_with(@pools) do |format|
|
|
format.xml do
|
|
render :xml => @pools.to_xml(:root => "pools")
|
|
end
|
|
end
|
|
end
|
|
|
|
def gallery
|
|
limit = params[:limit] || CurrentUser.user.per_page
|
|
@pools = Pool.series.search(search_params).reorder("updated_at desc").paginate(params[:page], :limit => limit, :search_count => params[:search])
|
|
@post_set = PostSets::PoolGallery.new(@pools)
|
|
end
|
|
|
|
def show
|
|
@pool = Pool.find(params[:id])
|
|
@post_set = PostSets::Pool.new(@pool, params[:page])
|
|
respond_with(@pool)
|
|
end
|
|
|
|
def create
|
|
@pool = Pool.create(pool_params)
|
|
flash[:notice] = @pool.valid? ? "Pool created" : @pool.errors.full_messages.join("; ")
|
|
respond_with(@pool)
|
|
end
|
|
|
|
def update
|
|
# need to do this in order for synchronize! to work correctly
|
|
@pool = Pool.find(params[:id])
|
|
@pool.attributes = pool_params
|
|
@pool.synchronize
|
|
@pool.save
|
|
unless @pool.errors.any?
|
|
flash[:notice] = "Pool updated"
|
|
end
|
|
respond_with(@pool)
|
|
end
|
|
|
|
def destroy
|
|
@pool = Pool.find(params[:id])
|
|
if !@pool.deletable_by?(CurrentUser.user)
|
|
raise User::PrivilegeError
|
|
end
|
|
@pool.update_attribute(:is_deleted, true)
|
|
@pool.create_mod_action_for_delete
|
|
flash[:notice] = "Pool deleted"
|
|
respond_with(@pool)
|
|
end
|
|
|
|
def undelete
|
|
@pool = Pool.find(params[:id])
|
|
if !@pool.deletable_by?(CurrentUser.user)
|
|
raise User::PrivilegeError
|
|
end
|
|
@pool.update_attribute(:is_deleted, false)
|
|
@pool.create_mod_action_for_undelete
|
|
flash[:notice] = "Pool undeleted"
|
|
respond_with(@pool)
|
|
end
|
|
|
|
def revert
|
|
@pool = Pool.find(params[:id])
|
|
@version = @pool.versions.find(params[:version_id])
|
|
@pool.revert_to!(@version)
|
|
flash[:notice] = "Pool reverted"
|
|
respond_with(@pool) do |format|
|
|
format.js
|
|
end
|
|
end
|
|
|
|
private
|
|
|
|
def pool_params
|
|
permitted_params = %i[name description category is_active post_ids]
|
|
params.require(:pool).permit(permitted_params)
|
|
end
|
|
end
|