evazion 60a13fd2d5 Fix #4913: Invalid replacements created if an error is raised during replacement ...

Perform the replacement in a before_create callback so that it runs in a
transaction and if it fails, the transaction will rollback and the
replacement record won't be created.

Doing the replacement in a transaction isn't great because, for one
thing, it could hold the transaction open a long time, which isn't good
for the database. And two, if the transaction rolls back, the database
changes will be undone, but if the replacement file has already been saved
to disk, then it won't be undone, which could result in a dangling file.

2022-02-01 01:14:41 -06:00

1.3 KiB

Raw Blame History

View Raw