b4ce2d83a6
The belongs_to_creator macro was used to initialize the creator_id field to the CurrentUser. This made tests complicated because it meant you had to create and set the current user every time you wanted to create an object, when lead to the current user being set over and over again. It also meant you had to constantly be aware of what the CurrentUser was in many different contexts, which was often confusing. Setting creators explicitly simplifies everything greatly.
72 lines
2.1 KiB
Ruby
72 lines
2.1 KiB
Ruby
require 'test_helper'
|
|
|
|
class PostApprovalTest < ActiveSupport::TestCase
|
|
context "a pending post" do
|
|
setup do
|
|
@user = FactoryBot.create(:user)
|
|
CurrentUser.user = @user
|
|
CurrentUser.ip_addr = "127.0.0.1"
|
|
|
|
@post = FactoryBot.create(:post, uploader_id: @user.id, tag_string: "touhou", is_pending: true)
|
|
|
|
@approver = FactoryBot.create(:user)
|
|
@approver.can_approve_posts = true
|
|
@approver.save
|
|
CurrentUser.user = @approver
|
|
|
|
CurrentUser.stubs(:can_approve_posts?).returns(true)
|
|
end
|
|
|
|
teardown do
|
|
CurrentUser.user = nil
|
|
CurrentUser.ip_addr = nil
|
|
end
|
|
|
|
should "allow approval" do
|
|
assert_equal(false, @post.approved_by?(@approver))
|
|
end
|
|
|
|
context "That is approved" do
|
|
should "create a postapproval record" do
|
|
assert_difference("PostApproval.count") do
|
|
@post.approve!
|
|
end
|
|
end
|
|
|
|
context "that is then flagged" do
|
|
setup do
|
|
@user2 = create(:user, created_at: 2.weeks.ago)
|
|
@user3 = create(:user, created_at: 2.weeks.ago)
|
|
@approver2 = FactoryBot.create(:user)
|
|
@approver2.can_approve_posts = true
|
|
@approver2.save
|
|
end
|
|
|
|
should "prevent the first approver from approving again" do
|
|
@post.approve!(@approver)
|
|
CurrentUser.user = @user2
|
|
@post.flag!("blah")
|
|
@post.approve!(@approver2)
|
|
assert_not_equal(@approver.id, @post.approver_id)
|
|
CurrentUser.user = @user3
|
|
travel(PostFlag::COOLDOWN_PERIOD + 1.minute) do
|
|
@post.flag!("blah blah")
|
|
end
|
|
|
|
approval = @post.approve!(@approver)
|
|
assert_includes(approval.errors.full_messages, "You have previously approved this post and cannot approve it again")
|
|
end
|
|
end
|
|
end
|
|
|
|
context "#search method" do
|
|
should "work" do
|
|
@approval = @post.approve!(@approver)
|
|
@approvals = PostApproval.search(user_name: @approver.name, post_tags_match: "touhou", post_id: @post.id)
|
|
|
|
assert_equal([@approval.id], @approvals.map(&:id))
|
|
end
|
|
end
|
|
end
|
|
end
|