Files
danbooru/test/functional/pools_controller_test.rb
evazion 29a4ca0818 pools: switch from search[name_matches] to search[name_contains].
The previous commit changed it so that `/pools?search[name_matches]`
does a full-text search. So for example, `search[name_matches]=smiling`
will now match pool names containing any of the words "smiling",
"smile", "smiles", or "smiled".

This commit adds a `/pools?search[name_contains]` param that does what
`name_matches` did before, and switches to it in search forms. So for
example, `search[name_contains]=smiling` will only match pool names
containing the exact substring "smiling".

This change is so that `<field>_matches` works consistently across the
site, and so that it's possible to search pool names by either an exact
substring match, or by a looser natural language match.

This is a minor breaking API change. API users can replace
`/pools?search[name_matches]` with `/pools?search[name_contains]` to get
the same behavior as before. The same applies to /favorite_groups.
2022-09-22 01:52:13 -05:00

134 lines
3.9 KiB
Ruby

require 'test_helper'
class PoolsControllerTest < ActionDispatch::IntegrationTest
context "The pools controller" do
setup do
travel_to(1.month.ago) do
@user = create(:user)
@mod = create(:moderator_user)
end
as(@user) do
@post = create(:post)
@pool = create(:pool, name: "Beautiful Smile", description: "[[touhou]]")
end
end
context "index action" do
should "list all pools" do
get pools_path
assert_response :success
end
should "render for a sitemap" do
get pools_path(format: :sitemap)
assert_response :success
assert_equal(Pool.count, response.parsed_body.css("urlset url loc").size)
end
should respond_to_search(name_contains: "eautiful").with { @pool }
should respond_to_search(name_contains: "beautiful smile").with { @pool }
should respond_to_search(name_contains: "smiling beauty").with { [] }
should respond_to_search(name_matches: "eautiful").with { [] }
should respond_to_search(name_matches: "beautiful smile").with { @pool }
should respond_to_search(name_matches: "smiling beauty").with { @pool }
should respond_to_search(linked_to: "touhou").with { @pool }
should respond_to_search(not_linked_to: "touhou").with { [] }
end
context "show action" do
should "render" do
get pool_path(@pool)
assert_response :success
end
end
context "gallery action" do
should "render" do
get gallery_pools_path
assert_response :success
end
end
context "new action" do
should "render" do
get_auth new_pool_path, @user
assert_response :success
end
end
context "create action" do
should "create a pool" do
assert_difference("Pool.count", 1) do
post_auth pools_path, @user, params: {:pool => {:name => "xxx", :description => "abc"}}
end
end
end
context "edit action" do
should "render" do
get_auth edit_pool_path(@pool), @user
assert_response :success
end
end
context "update action" do
should "update a pool" do
put_auth pool_path(@pool), @user, params: { pool: { name: "xyz", post_ids: [@post.id] }}
assert_equal("xyz", @pool.reload.name)
assert_equal([@post.id], @pool.post_ids)
end
should "not allow updating unpermitted attributes" do
put_auth pool_path(@pool), @user, params: { pool: { is_deleted: true, post_count: -42 }}
assert_equal(false, @pool.reload.is_deleted?)
assert_equal(0, @pool.post_count)
end
end
context "destroy action" do
should "destroy a pool" do
delete_auth pool_path(@pool), @mod
@pool.reload
assert_equal(true, @pool.is_deleted?)
end
end
context "undelete action" do
setup do
as(@mod) do
@pool.is_deleted = true
@pool.save
end
end
should "restore a pool" do
post_auth undelete_pool_path(@pool), @mod
@pool.reload
assert_equal(false, @pool.is_deleted?)
end
end
context "revert action" do
setup do
@post_2 = as(@user) { create(:post) }
@pool = as(@user) { create(:pool, post_ids: [@post.id]) }
as(@mod) { @pool.update!(post_ids: [@post.id, @post_2.id]) }
end
should "revert to a previous version" do
put_auth revert_pool_path(@pool), @mod, params: { version_id: @pool.versions.first.id }
assert_redirected_to @pool
assert_equal([@post.id], @pool.reload.post_ids)
end
should "not allow reverting to a previous version of another pool" do
@pool2 = as(@user) { create(:pool) }
put_auth revert_pool_path(@pool), @user, params: {:version_id => @pool2.versions.first.id }
@pool.reload
assert_not_equal(@pool.name, @pool2.name)
assert_response :missing
end
end
end
end