Commit Graph

7700 Commits

Author SHA1 Message Date
Albert Yi
0508b127fd continue refactoring savedsearch 2018-11-15 12:06:13 -08:00
Albert Yi
df02eb7951 eliminate listbooru references 2018-11-12 18:02:49 -08:00
Albert Yi
a57d4a9558 fixes #2680 2018-11-12 16:29:44 -08:00
evazion
bea8c2a4b8 nijie: fix failure to handle certain image urls.
Fix IMAGE_URL regex not matching urls of this form:

* https://pic04.nijie.info/nijie_picture/diff/main/287736_161475_20181112032855_1.png

This caused the illust id to not be parsed from the url, which led to `#image_url`
returning nil, which led to uploads failing because the url to download was missing.
2018-11-12 18:04:07 -06:00
evazion
8f6c710c6b tests: fix translated tags test failures. 2018-11-12 18:04:07 -06:00
Albert Yi
8344ad7a9b user string for matomo user id 2018-11-12 10:34:53 -08:00
Albert Yi
5493e16f04 tweak matomo tracking 2018-11-12 10:28:48 -08:00
evazion
7524d52276 Fix #3985: Uploads: 405 Method Not Allowed. 2018-11-11 20:18:21 -06:00
evazion
6a7cd6ce8e Fix #3984: Twitter: undefined method `first' for nil:NilClass.
Fix Sources::Strategies::Twitter#image_urls to return an empty array
instead of nil when the tweet doesn't contain any images.
2018-11-11 17:41:32 -06:00
evazion
a20eba9ef7 Fix #3983: Uploads: NoMethodError - undefined method `>=' for nil:NilClass
* Rename Upload#download_for_upload to #get_file_for_upload.

* Fix #get_file_for_upload to raise error if no file or source url was given.

* Fix javascript upload validation to disallow submitting form if file is
  not present and the source is not an url.
2018-11-11 17:12:39 -06:00
evazion
e10c6c6a30 Fix #3982: Uploads: URI::InvalidURIError - URI must be ascii only. 2018-11-11 12:17:58 -06:00
evazion
eade33fa7c Fix #3981: Inconsistency between posts and pools. 2018-11-10 12:37:08 -06:00
Albert Yi
684e2bdbad fix undefined _paq references 2018-11-09 15:49:42 -08:00
Albert Yi
c8793457cb remove mixpanel + add more matomo tracking 2018-11-09 15:40:38 -08:00
evazion
e69cbe7f81 pools: post_count fixups. 2018-11-08 19:35:17 -06:00
Albert Yi
0747284124 add without_timeout blocks on migrations 2018-11-08 14:24:45 -08:00
Albert Yi
7c86d3a2e0 Merge pull request #3980 from evazion/fix-3979
Fix #3979 - Pools: store post_ids as array instead of string
2018-11-08 14:24:08 -08:00
evazion
fb7d83c54f pools: drop post_count column (fix #3667) 2018-11-08 15:35:41 -06:00
evazion
115ed16a96 pools: store post_ids as array instead of string (fix #3979) 2018-11-08 15:09:31 -06:00
Albert Yi
8515bf43b4 make popular tags for order:rank higher priority in list 2018-11-07 16:30:14 -08:00
evazion
572645d888 pools: cleanup unneeded code.
* create_mod_action_for_destroy didn't exist (pools are never destroyed).

* is_active and is_deleted are already initialized via database defaults.

* creator_name is already defined by belongs_to_creator.

* Returning true/false in validations does nothing.
2018-11-07 16:10:36 -06:00
evazion
1281481548 Fix #3978: Pool name/category validations not being enforced. 2018-11-07 16:10:16 -06:00
evazion
a6aa75873d Fix #3976: DText external links appear broken. 2018-11-06 20:17:45 -06:00
evazion
ed47db0e48 upload tags report: add controller test (#3975). 2018-11-06 18:29:27 -06:00
evazion
5c4a310589 Fix #3975: Upload tags report is broken. 2018-11-06 18:18:18 -06:00
Albert Yi
c2e0763986 default to pool gallery from main navlinks 2018-11-06 15:55:18 -08:00
evazion
bd0bb658b8 Fix #3974: Pool galleries: link thumbnails to pools instead of posts. 2018-11-06 14:33:04 -06:00
evazion
841104f09a post presenter: fixup typo in 26c1eadf. 2018-11-06 13:15:09 -06:00
evazion
ff9ce25b01 Fix #3973: Pool gallery is broken. 2018-11-06 13:11:11 -06:00
evazion
26c1eadf6a modqueue: move score highlighting from js to presenter.
The 'post-has-children' class was dropped because it was unused
('post-status-has-children' is already added elsewhere).
2018-11-06 10:42:48 -06:00
evazion
2eb284f31e modqueue: simplify detailed rejection dialog js. 2018-11-06 10:42:48 -06:00
evazion
b730a86870 modqueue: clear detailed rejection form before each use.
Bug: in the modqueue, if a user does a detailed rejection of one post,
then tries to do a detailed rejection of another post, the form will
still be filled in with the rejection message from the previous post.
2018-11-06 10:42:48 -06:00
r888888888
8da51b4555 change default response for empty popularsearchservice response 2018-11-05 21:35:57 -08:00
evazion
00f36605c4 modqueue: fix typo in 1d3eb584c 2018-11-05 17:27:33 -06:00
Albert Yi
1d3eb584c7 fix new postpresenter styles 2018-11-05 15:11:27 -08:00
Albert Yi
9ddb9cd434 use only 1 copyright tag by default in humanized essential tag string 2018-11-05 14:34:07 -08:00
evazion
1cba439589 Fix #3971: Keyboard navigation inside pools is broken. 2018-11-05 13:04:21 -06:00
evazion
5b3f3253a4 related tags: fix broken translated tag names
ref: https://danbooru.donmai.us/forum_topics/9127?page=261#forum_post_152040
2018-11-05 12:54:53 -06:00
evazion
98cffc310b Fix pool elements controller tests. 2018-11-04 21:25:25 -06:00
evazion
29b6121a07 pools: refactor #neighbors + fix broken #neighbors tests. 2018-11-04 19:40:57 -06:00
evazion
628341f7f0 Fix #3969: Translated tags should ignore artist tags. 2018-11-04 17:07:35 -06:00
evazion
19b92acabc Fix #3970: Make "Copy all notes" not builder exclusive. 2018-11-04 16:42:55 -06:00
evazion
0152cbe39e moebooru: fix delegation to nil strategy (fixup for 5cf6a43). 2018-11-04 15:24:22 -06:00
evazion
c7e6c2a44a posts: fix pixiv id parsing (fixup for 5cf6a43) 2018-11-04 14:22:29 -06:00
evazion
5cf6a43918 sources: fix sources sometimes choosing wrong strategy (fix #3968)
Fix sources choosing the wrong strategy when the referer belongs to a
different site (for example, when uploading a twitter post with a pixiv
referer).

* Fix `match?` to only consider the main url, not the referer.

* Change `match?` to match against a list of domains given by the `domains` method.

* Change `match?` to an instance method.
2018-11-04 13:00:17 -06:00
Albert Yi
4219163042 add mixpanel tracking for clicking stripe buttons 2018-11-02 17:03:24 -07:00
Albert Yi
5d83864131 fix bug with post previews 2018-11-02 16:38:28 -07:00
Albert Yi
08da9e7104 show popular tags when showing order:rank 2018-11-02 16:18:53 -07:00
Albert Yi
1a41ccf7ba fix ids of post previews 2018-11-02 15:51:14 -07:00
Albert Yi
9cfbda64bf fixes #3967 2018-11-02 14:21:41 -07:00