jaculabilis/danbooru
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
6,678 Commits 1 Branch 0 Tags
3933c273c407b56e2cbd7babcdb3b7c0f3b77cc4
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
evazion 2833239fa0 Fix #3513: Missing rating error causes weird behavior in tag list on upload page. 
Fix bug in the double submit prevention from #2789. Rather than
unbinding the enter key on submit, have the enter key click the submit
button instead. This avoids form submission when the submit button is disabled.
 2018-01-21 11:55:24 -06:00
evazion 46b0f9e6d6 Update dotenv. 
dotenv-2.2.1 no longer loads .env.local in the test environment. Load it
manually for backwards compatibility.
 2018-01-20 19:04:48 -06:00
evazion 074a4be38f Update gems. 2018-01-20 19:04:48 -06:00
evazion a923a64220 tests: fix pixiv profile image test. 2018-01-20 14:51:05 -06:00
evazion 53f7207716 tests: remove bad_id pixiv test. 2018-01-20 14:50:44 -06:00
evazion 57c4d2a54f related tag calculator: fix unstable sorting of related tags. 
Fix this test failure:

    1) Failure:
    RelatedTagCalculatorTest#test_: A related tag calculator should convert a hash into string format.
    [test/unit/related_tag_calculator_test.rb:65]:
    Expected: "aaa 3 bbb 3 ccc 2 ddd 1"
      Actual: "bbb 3 aaa 3 ccc 2 ddd 1"

The related tag string didn't use a stable sort. Sort first by tag
count, then by tag name.
 2018-01-20 14:33:36 -06:00
evazion e596a7fd0f tests: fix <char>_(cosplay) alias test. 2018-01-20 14:26:16 -06:00
evazion 83ab90d495 tests: fix tag removal warning tests. 2018-01-20 13:59:21 -06:00
evazion 2deefcc090 Fix exception when viewing /favorite_groups while logged out. 
Also fixes a test failure in the favgroups controller tests.
 2018-01-20 13:47:41 -06:00
evazion e47c983cfd tests: fix pawoo tags test. 2018-01-20 13:25:13 -06:00
evazion c29785268d tests: fix iqdb controller test (#3479). 2018-01-20 13:22:05 -06:00
evazion ce06736374 tests: fix timestamp comparison in artist notes saving test. 
Equality test failed due to microsecond level differences. Truncate to
seconds to avoid this.
 2018-01-20 13:08:40 -06:00
evazion 3d09ce5e55 tests: fix status:active test for #3472. 2018-01-20 12:50:30 -06:00
evazion 989854b3dd Fix #3507: Include ban length in feedback. 2018-01-17 19:53:49 -06:00
evazion 7a0fb0f5d3 Fix #3500: Redirect API endpoints with md5 query param to correct format. 2018-01-14 20:36:57 -06:00
evazion 88f4a56890 Fix #3497: Invalid DText denial of service attack. 2018-01-14 16:14:18 -06:00
evazion 4f543671a2 tests: move test/helpers to test/test_helpers. 
The Rails convention is for test/helpers to be used for testing the view
helpers in app/helpers. We were using it to store certain utility
methods instead. Move these to test/test_helpers so that test/helpers
can be used for its intended purpose.
 2018-01-14 16:11:15 -06:00
evazion 7c8cfc1e31 Fix #3492: Add corrupted_image to list of default removed tags for replacements. 2018-01-03 17:44:59 -06:00
evazion f710710cbb PostSets::Post#hide_from_crawler?: hide all metatag searches from crawlers. 2017-12-31 12:27:05 -06:00
evazion f9ffa2b47a Fix #3484: /posts: don't show wiki tab for metatags. 2017-12-31 12:25:17 -06:00
evazion 89b523bdae Fix #3480: NoMethodError error when adding artist tag to post. 2017-12-30 16:07:52 -06:00
evazion 3e936748c0 Fix #3468: Approval queue should not show one's own uploads or previous approvals. 2017-12-28 19:36:37 -06:00
evazion 1ca2497015 Fix #3474: Spurious email notifications. 2017-12-28 18:50:08 -06:00
evazion 857fa24697 Fix #3473: Validation warnings for no artist/copyright are still shown on upload failure. 2017-12-28 18:19:28 -06:00
evazion d8eef6ef2b Fix #1563: Warn users attempting to upload with very few tags. 2017-12-27 15:04:00 -06:00
evazion ad74d9e75a Fix #3464: CurrentUser.ip_addr isn't set for anonymous users. 2017-12-27 13:34:20 -06:00
evazion 1fc2284874 /users/new: show error message when account signup fails. 2017-12-27 13:34:20 -06:00
evazion 32ac09ee48 Add test for registering sock puppet accounts. 2017-12-27 13:33:57 -06:00
evazion 48b67967b5 Fix #3457: Timeout when fetching source data from NicoSeiga. 2017-12-27 13:08:14 -06:00
evazion e34754c65c Possible fix for #3460: Timeout in update_last_ip_addr. 
Set the user's statement timeout as soon as possible, before updating
anything in the database.
 2017-12-27 12:42:11 -06:00
evazion 952b5f9245 Fix bogus artist finder matches for http://www.nicovideo.jp/user/1234. 2017-12-26 14:31:42 -06:00
evazion 86f1ec5919 Fix #3459: Batch Bookmarklet for Artstation returns wrong results. 2017-12-26 14:05:41 -06:00
evazion 0d69c03249 Fix "undefined method `is_builder?' for nil:NilClass" in static/error.html.erb. 
`CurrentUser.user` may be nil if an exception is raised before it's
initialized.
 2017-12-23 18:27:04 -06:00
evazion 5f1b7da95d Fix "RuntimeError: can't modify frozen String" in static/error.html.erb. 
Fixes a frequently occurring error in New Relic.
 2017-12-23 18:23:41 -06:00
evazion 91592b2f18 Fix #3448: Lower the limit for tag category changes. 
Also allow admins to bypass all restrictions.
 2017-12-23 13:44:45 -06:00
evazion 2385933e56 tags: fix /tags/1234/edit not enforcing correct category change restrictions. 2017-12-23 13:41:18 -06:00
evazion 19bda2056c tags: update category cache whenever category changes. 
Do `update_category_cache_for_all` in a callback instead of calling it
manually everywhere.
 2017-12-23 13:07:23 -06:00
evazion 265377bdbb Fix #3450: Aliased tags show up under translated tags. 
Resolves aliases in translated tags. For example, say we lookup `遠坂凛`
and find `tohsaka_rin` and `toosaka_rin`. We apply aliases so that
`tohsaka_rin` becomes `toosaka_rin`, which is then returned as the only
translated tag.
 2017-12-23 12:27:58 -06:00
evazion 6243cc8d48 Fix invalid routes for /posts, /explore/posts. 
Fixes these invalid routes:

* GET http://danbooru.donmai.us/posts/new
* GET http://danbooru.donmai.us/posts/1234/edit
* POST http://danbooru.donmai.us/posts
* DELETE http://danbooru.donmai.us/posts
* GET http://danbooru.donmai.us/explore/posts
 2017-12-23 11:31:12 -06:00
evazion 806513836b Fix failbooru in /users/custom_style.css when custom_style is nil. 
http://danbooru.donmai.us/users/custom_style.css failed when manually
requested by anonymous users, or by users who didn't have a style set.
 2017-12-23 11:11:50 -06:00
evazion 20b84578a2 Fix "The action 'show' could not be found for FavoritesController" 
Fixes an exception on "/favorites/1234" requests.
 2017-12-23 00:56:40 -06:00
evazion 5975152ddc Fix double render error in /blah.js. 2017-12-23 00:45:07 -06:00
evazion fcec99405c Fix failure in rake db:migrate on fresh install (#3443). 
Create the DanbooruBot account in db/seeds.rb instead of in an
initializer. Move the old db/seeds.rb to db/populate.rb.

Fixes a bug introduced in e2eb45a. Creating DanbooruBot in an
initializer was wrong because in a fresh install the users table doesn't
exist yet. This caused `rake db:migrate` to fail.
 2017-12-21 12:08:08 -06:00
evazion 8c44789fbc Fix #3440: Implications aren't applied to automatic tags. 
Apply implications after adding automatic tags.
 2017-12-19 14:37:12 -06:00
evazion b711566c14 Fix #3438: Thumbnails on user profiles don't respect safe mode. 2017-12-19 13:58:41 -06:00
evazion 4b5129d447 lib/tasks/images.rake: fix bad ref to danbooru_image_resizer. 
Fixup for efeaad25.
 2017-12-18 18:08:41 -06:00
evazion fa941e9480 /post_replacements: allow updating image metadata in past replacements. 2017-12-18 18:03:03 -06:00
evazion e6acd6f2d6 /post_replacements: list old and new md5 and image sizes. 2017-12-18 18:03:03 -06:00
evazion eede2f0752 Fix #3324: Incorporate replacement comment info in the replacement history. 2017-12-18 18:02:43 -06:00
evazion efeaad25ca Move lib/danbooru, lib/danbooru_image_resizer to app/logical. 2017-12-18 12:07:52 -06:00
evazion 859fe99a80 Fix #2696: Bogus results on non-matching URL searches for Artists 2017-12-17 21:00:34 -06:00
evazion 2a876991da Accept search[created_at] and search[updated_at] params in all controllers. 2017-12-17 17:37:26 -06:00
evazion 0ca726802f Fix #3430: Accept the search[id] param in all controllers. 
* Allow every controller to take the `search[id]` param.

* Parse the `search[id]` param the same way that the `id:<N>` metatag is
  parsed. So `search[id]=1,2,3`, `search[id]=<42`, `search[id]=1..10`, for
  example, are all accepted.
 2017-12-17 17:36:52 -06:00
evazion 86936f7200 Artist#find_all_by_url: refactor hardcoded bogus urls to blacklist. 2017-12-17 14:14:21 -06:00
evazion 49577e3fac /static/bookmarklet: add note using bookmarklet on Twitter with Firefox. 
In Firefox, to use the bookmarklet on Twitter you must install version
1.1.3 of the Bookmarklets Context Menu addon. See https://danbooru.donmai.us/forum_topics/14794.
 2017-12-16 12:59:02 -06:00
evazion 002b5e385a Autoban dmail spambots (#3408). 
If a user sends spam to more than 10 users within a 24 hour window,
automatically ban them for 3 days.
 2017-12-15 19:14:27 -06:00
evazion e2eb45a5a3 Auto-promote DanbooruBot to Mod. Auto-create DanbooruBot if it doesn't exist. 2017-12-15 18:54:18 -06:00
evazion b48211cd4a dmails: only spam check recipient's copy of the dmail. 
Each dmail creates two copies, one for the sender and one for the
receiver. Only spam check the receiver's copy.

Prevents senders from being able to tell when their messages are being
spam filtered.
 2017-12-15 18:54:18 -06:00
evazion 3ce8f6e7df /wiki_pages/show_or_new: show post count in navbar if tag exists (#3410). 
649969156 hid the post count in the navbar on /wiki_pages/new, but that
also hid the count for /wiki_pages/show_or_new?title=medium_hair, which
was wrong. Show the count when the tag exists.
 2017-12-15 11:54:56 -06:00
evazion d2df35092b /user_feedbacks: display "Updated N minutes ago" on edited feedbacks (#3423). 2017-12-15 11:16:24 -06:00
evazion 03cecf097e Factor out duplicated p.info CSS. 
`p.info` is used to render "Updated by so-and-so 5 minutes ago" messages as fine print.
 2017-12-15 11:14:12 -06:00
evazion 4c39783d28 Fix #3424: /iqdb_queries.json fails for certain urls. 
Fix the HTML page -> image URL download rewrite strategy failing for
https://lohas.nicoseiga.jp/thumb/${id}i URLs.
 2017-12-15 10:16:06 -06:00
evazion 5819afced7 Fix #3412: Mass updates incorrectly move saved searches. 2017-12-06 14:46:12 -06:00
evazion d6d73404a9 Apply aliases to characters in <character>_(cosplay) tags (#3409). 2017-12-06 12:47:27 -06:00
evazion 131c0109d4 Address #3415: og:image meta tags can point to video files. 2017-12-06 09:47:57 -06:00
evazion acd49be4cc Fix #3419: Deleting a post doesn't clear parent's "parent" status. 
Bug: when deleting a child post and the "Move favorites to parent?" option is
set, the parent's has_active_children flag is not cleared.

`give_favorites_to_parent` moves the votes, and moving the votes has the
side effect of reloading the post (to get the new score). But reloading
the post wipes out the is_deleted_changed? flag, which is used by `update_parent_on_save`.

Fix: update the `is_deleted` flag *before* moving favorites, so that the
`update_parent_on_save` callback runs before `give_favorite_to_parent` runs.
 2017-12-05 19:35:15 -06:00
evazion feb3ec0750 Fix #3417: Deleting a user's comment credits the change to them. 2017-12-02 19:41:37 -06:00
evazion 8d8a2f9c1e Make recaptcha optional on signup page. 2017-11-29 18:09:37 -06:00
evazion 2000719227 /wiki_pages: get navbar post count from tags table. 
Post.fast_count is dependent on the current user's settings. This meant
that tag counts in wiki pages could be different from the tag counts
displayed in tag lists.
 2017-11-29 13:12:53 -06:00
evazion 649969156e /wiki_pages: don't show post count in navbar when creating new wikis. 2017-11-29 12:56:58 -06:00
evazion 3c6a613964 Fix #3410: Unable to create a new wiki page. 
Fix `Post.fast_count(nil)` failing when the user had the "safe mode" or
"deleted post filter" options turned on.
 2017-11-29 12:34:07 -06:00
evazion dd8e3bbb94 tags: add trigram index on tag names. 2017-11-27 15:21:19 -06:00
evazion 44f4befa5a autocomplete: add automatic typo correction. 
If normal autocomplete fails to find any results, try doing a
fuzzy name search instead. This will correct simple typos.
 2017-11-27 15:21:19 -06:00
evazion f4d279771f /tags: add fuzzy name search params (search[fuzzy_name_matches], search[order]=similarity). 2017-11-27 15:21:19 -06:00
evazion 4939c0345a Fix test failures when removing posts from deleted pools. 
These tests failed because removing posts from deleted pools is now
Builder-only.
 2017-11-26 18:10:08 -06:00
evazion a7566ae851 post_view_count_service_test.rb: fix test failure. 2017-11-26 16:17:21 -06:00
evazion 255082d3b5 tumblr: fix test failure. 2017-11-26 15:37:51 -06:00
evazion 1c5c3b5f9f Include paginator extensions in ApplicationRecord. 2017-11-26 15:34:44 -06:00
evazion ec6d553fa6 Move execute_sql / select_value_sql etc to ApplicationRecord. 2017-11-26 13:57:52 -06:00
evazion 45cecff1a6 Move with_timeout / without_timeout to ApplicationRecord. 2017-11-26 13:57:52 -06:00
evazion 5b89f56c2e Move PostgresExtensions to ApplicationRecord. 2017-11-26 13:57:51 -06:00
evazion 8a0f600ac2 uploads: fix rating:S not being recognized by rating validator. 2017-11-26 11:54:13 -06:00
evazion 6d9708a22e posts: don't warn about missing artist tags for official_art. 2017-11-26 11:43:46 -06:00
evazion 80e115b600 favgroups: fix race condition when adding posts to favgroups. 
Adding or removing a post id to a favgroup's post_ids string is
non-atomic. Lock it to prevent simultaneous updates to the same favgroup
from clobbering each other.

Same bug as #3091.
 2017-11-26 11:02:39 -06:00
evazion 810b6b8b99 Fix #3039: Test failures under ruby 2.4. 2017-11-25 21:52:32 -06:00
evazion 127e4e385b Fix dmail failures when akismet isn't configured. 2017-11-25 21:46:32 -06:00
evazion bc3e2438d9 posts: add tests for warning validations. 2017-11-25 17:03:33 -06:00
evazion cc1f8ab9ed posts: warn when a tag cannot be removed due to implications / automatic tags. 2017-11-25 17:03:33 -06:00
evazion 94fa835733 posts: warn when post from known source is missing an artist tag. 2017-11-25 17:03:33 -06:00
evazion 4cd372296d posts: warn when post is missing copyright tags. 2017-11-25 17:03:33 -06:00
evazion d571efd703 posts: warn when adding artist tag with no artist entry. 2017-11-25 17:03:33 -06:00
evazion 963eacd849 posts: warn when adding newly created tags. 2017-11-25 17:03:32 -06:00
evazion 07a4bdcb21 posts: display validation warnings in flash notice. 2017-11-25 17:03:32 -06:00
evazion aeb24b6253 Fix "Similarity: %98" -> "Similarity: 98%". 2017-11-25 16:50:12 -06:00
evazion b62b16b5a2 Fix #3398: Show "(deleted)" next to topics in forum searches. 2017-11-24 15:58:45 -06:00
evazion 0b5ed163fe Fix #3395: fix pixiv API exception when uploading bad pixiv id images. 
Fixes an exception when attempting to upload a Pixiv image from a
deleted work. The download strategy tries to fetch the source data in
the course of rewriting the URL, which fails if the work has been
deleted from Pixiv.

Raise a BadIDError and leave the URL as-is (don't rewrite it).
 2017-11-21 14:40:39 -06:00
evazion 183a7e07e3 pixiv: fix failbooru when uploading bad pixiv id posts. 
Fixes an "incompatible character encodings: UTF-8 and ASCII-8BIT"
exception when uploading a deleted Pixiv post.

Caused by the Pixiv API error message not having the encoding set to UTF-8.
 2017-11-21 14:11:59 -06:00
evazion 5ba63733d3 download/pixiv_test.rb: fix broken pixiv download tests. 
This post was deleted:

  http://www.pixiv.net/member_illust.php?mode=medium&illust_id=46304614

Switch to this instead:

  http://www.pixiv.net/member_illust.php?mode=medium&illust_id=46324488
 2017-11-21 13:48:07 -06:00
evazion a14c492020 Fix #3396: Pixiv novel cover IDs are parsed incorrectly. 2017-11-21 13:03:03 -06:00
evazion f8581c8113 Fix #3321: HTML tags not converted in artist commentaries. 2017-11-21 02:42:49 -06:00