jaculabilis/danbooru
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
7,803 Commits 1 Branch 0 Tags
3f95b5163c739038d0547adfa9d6e9f4462ea8f1
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
evazion 80f43f9a7c Fix #4038: Attempting to create an IP-ban bans the creator. 
* Rename comments.ip_addr to comments.creator_ip_addr.
* Fix belongs_to_creator to not clobber ip_addr field.
 2019-01-09 16:20:34 -06:00
evazion 5c54c61d65 Fix #4035: The Related Tag JSON endpoint is returning the wrong information 
* Fix /related_tags.json to return a list of tags in the `other_wikis` field.

* Add support for /related_tags.xml.
 2019-01-07 13:30:10 -06:00
evazion 04d5b16da7 pixiv: fix failure to upload bad pixiv id images (fix #4031) 
Bug: Uploading bad pixiv id images failed because the pixiv strategy
raised a BadIDError exception when the upload service checked for the
ugoira frame data.
 2019-01-03 18:01:20 -06:00
evazion 7478c7a913 Fix #4034: Several keyboard shortcuts are missing an ID. 2019-01-03 17:19:16 -06:00
evazion 886096b47a BURs: fix remove alias command removing inactive aliases. 
Fix the `remove alias` and `remove implication` commands to only remove
active aliases or implications, not pending/deleted/retired ones.
 2019-01-03 16:30:39 -06:00
evazion 82b09860f2 Fix #4032: /tag_aliases page is broken. 2019-01-02 15:55:24 -06:00
evazion d32882e1ee aliases/implications: fix controller tests. 2018-12-31 19:08:15 -06:00
evazion 0ab2dfc5d2 aliases/implications: fix conflicting definitions of active scope. 2018-12-31 19:03:01 -06:00
evazion 17a5db72a6 aliases/implications: allow searching by antecedent or consequent tag type. 2018-12-31 18:55:36 -06:00
evazion fd1c9dbf30 aliases/implications: add active/deleted/processing statuses to search form. 2018-12-31 18:29:25 -06:00
evazion aceded710a aliases/implications: fix retired aliases being sorted first on index page. 2018-12-31 17:07:14 -06:00
evazion d393d67a9b aliases/implications: don't destroy removed aliases (#4024). 2018-12-31 17:07:14 -06:00
evazion f5116c5ce2 aliases/implications: allow duplicate inactive aliases/implications. 
Allow multiple pending, deleted or retired aliases/implications for the
same tag.

This is so that deleted or retired aliases can be resubmitted as new
pending requests.
 2018-12-31 17:07:14 -06:00
evazion 44a54f75cd tests: don't automatically approve aliases/implications on creation. 
Automagically approving inactive aliases makes testing more difficult.
 2018-12-31 17:07:14 -06:00
evazion 341403c7bb tests: fix broken bulk update request test. 2018-12-31 17:07:14 -06:00
evazion b12e8b5058 Fix #4030: Artstation artist_name broken for direct image urls. 2018-12-31 11:45:50 -06:00
evazion ff62b63bab notes: whitelist the 'mask' css property. 
ref: https://danbooru.donmai.us/forum_topics/9127?page=266#forum_post_153530
 2018-12-29 12:08:02 -06:00
evazion fde398d37b posts: clarify missing artist tag warning (#4029). 2018-12-28 15:52:49 -06:00
evazion 6a77b68b74 tumblr: fix tests. 2018-12-27 15:03:11 -06:00
evazion 0f513d1a1b twitter: include intent url in new artist entries (#4028). 2018-12-27 15:03:11 -06:00
evazion 2129e60b2b pixiv: include stacc url in new artist entries (#4028). 2018-12-27 15:03:11 -06:00
evazion 1f73e60514 sources: add methods for customizing new artist entries. 
* Rename `unique_id` to `tag_name`.

* Add `other_names` and `profile_urls` methods that sources can override
  to provide extra names or urls when creating new artist entries.
 2018-12-27 15:03:11 -06:00
evazion 2170961f47 artists: improve prefilling of new artist form (#4028) 
* When creating an artist by clicking the '?' next to the artist tag in
  the tag list, prefill the new artist form by finding the artist's last
  upload and fetching its source data.

  Previously we filled the urls with the source of the artist's last
  upload, which was wrong because it was usually a direct image URL (#3078).

* Fix the other names field not escaping spaces within names to underscores.

* Fix the other names field being potentially prefilled with duplicate names.
 2018-12-27 15:03:11 -06:00
evazion 286bf2f285 artists: filter out duplicates from other names (#4028). 2018-12-27 15:03:11 -06:00
evazion 0dd44e64a4 artists: add notice about separating other names with spaces (#4028). 2018-12-27 15:03:11 -06:00
evazion 3c9b26c247 tests: fix *_(cosplay) tagging test (fixup for 51b08d224). 2018-12-26 20:16:59 -06:00
evazion 719f556dd5 aliases: warn about conflicting wikis when alias is requested. 
* Warn about conflicting wiki pages during secondary validation.

* Only warn about missing wiki if both tags are missing a wiki page.
 2018-12-26 17:30:07 -06:00
evazion 365e04b5f9 implications: fix validation of circular implications. 
Fix bug where circular chains like `a -> b && b -> c && c -> a` were
allowed.
 2018-12-26 17:30:07 -06:00
evazion 51b08d2243 implications: ensure antecedent/consequent tags exist. 2018-12-26 17:30:07 -06:00
evazion c27ba02b88 aliases/implications: clean up validations. 
* Don't return true/false in validations (does nothing).
* Prefer `errors[:base]` over `self.errors[:base]`.
* Add antecedent_wiki / consequent_wiki associations.
* Factor out antecedent_and_consequent_are_different validation.
 2018-12-26 17:30:07 -06:00
evazion 3e382bd831 Fix #4014: Incorrect tag type counts on posts. 2018-12-19 12:20:29 -06:00
evazion 3adf24c0aa tag edit dialog: fix popout link not always being bound. 
Fix the popout link not being bound on the upload page when uploading
without the bookmarklet.
 2018-12-18 19:23:59 -06:00
evazion b24ccb0595 tag edit dialog: fix clicking button before handler is bound. 
https://danbooru.donmai.us/forum_topics/9127?page=265#forum_post_153180:

> I'm not sure how to reproduce this, but sometimes on the upload page
> when I click the button to pop out the tag box, the screen scrolls up to
> the picture but the box doesn't pop out, and I have to scroll back down
> and click it again

https://danbooru.donmai.us/forum_topics/9127?page=266#forum_post_153183:

> Yes, this was brought up by Unbreakable on Discord a while back. It's
> due to the fact that the event handler that pops out the dialog box has
> not yet been bound by the time you click it. Since that clickable
> control has an empty anchor link of "#" which goes nowhere, it therefore
> redirects the user to the top of the page.
 2018-12-18 19:10:23 -06:00
evazion d52d5ff260 Fix #4018: Drag and drop upload errors 
Disable upload timeout. This timeout caused uploads to silently fail when
the timeout was exceeded (ref: https://gitlab.com/meno/dropzone/issues/23).
 2018-12-16 17:45:26 -06:00
evazion 8408c0bf80 Fix #3815: Adjust notes positions/sizes after post replacement 
Bug: Notes weren't rescaled when the 'final_source' field was given
during replacement.

The cause was that the notes were rescaled after the source was saved,
but saving the source clobbered `image_{width,height}_before_last_save`
inside `rescale_notes`.

Regressed in b0c2ddba.
 2018-12-16 13:55:35 -06:00
evazion d2f92b7aa7 artists: fix quick search to search urls. 
ref: https://danbooru.donmai.us/forum_topics/9127?page=265#forum_post_153124
 2018-12-16 12:07:50 -06:00
evazion 004f1e630d binstubs: revert to rails binstubs (77b42310) 
Silence complaints from rails about using Bundler-generated binstubs.
 2018-12-16 11:50:16 -06:00
evazion c700ea4b5f Fix #4016: Translated tags failing to find some tags. 
* Normalize spaces to underscores when saving other names. Preserve case
  since case can be significant.

* Fix WikiPage#other_names_include to search case-insensitively (note:
  this prevents using the index).

* Fix sources to return the raw tags in `#tags` and the normalized tags
  in `#normalized_tags`. The normalized tags are the tags that will be
  matched against other names.
 2018-12-16 11:37:57 -06:00
evazion a1df1abf0b Fix #4020: Flagger name information leak. 2018-12-14 18:08:43 -06:00
evazion 9de5857032 Fix #4015: Exception: undefined method `level_class' for nil:NilClass. 2018-12-12 17:57:29 -06:00
evazion 79ec053cef Fix #4009: Tag list is empty when editing tags, causing destructive changes. 2018-12-12 13:02:04 -06:00
evazion 957d1527d1 autocomplete: add order:*_count metatags. 2018-12-11 18:10:20 -06:00
evazion ea9c3576d8 search: add synonyms for *_count metatags. 
Allow e.g. `deleted_comments` as a synonym for `deleted_comment_count`.
 2018-12-11 18:10:20 -06:00
evazion b1335616dd search: add {flag,appeal,approval,replacement,child,pool}_count metatags (#4004). 2018-12-11 18:10:20 -06:00
evazion 4a1f0523a4 search: add comment_count, note_count metatags (#4004). 
Add these metatags:

* comment_count
* deleted_comment_count
* active_comment_count
* note_count
* deleted_note_count
* active_note_count
* order:comment_count
* order:deleted_comment_count
* order:active_comment_count
* order:note_count
* order:deleted_note_count
* order:active_note_count
 2018-12-11 18:10:20 -06:00
evazion 37b2214472 post_tags_match: replace joins with subqueries. 
Refactor various post_tag_match methods to use subqueries instead of joins.

This simplifies things inside PostQueryBuilder, since now we can assume
we're always dealing with a Post relation, rather than some other table
joined with the posts table.
 2018-12-11 18:10:20 -06:00
evazion cacc899a4d autocomplete: limit static metatags to 10 matches. 
Prevents autocomplete menu from becoming excessively long when
completing order: metatags.
 2018-12-11 12:02:18 -06:00
evazion 28f32abe24 Fix migrations. 2018-12-10 19:38:56 -06:00
evazion fe60672ef3 Fix #4005: Add confirmation for unbanning a post. 2018-12-10 00:39:02 -06:00
evazion 61f6de5ff3 artist versions: rearrange layout to better fit small screens. 
* Move group name beneath the artist name.
* Replace 'Active' column with '(deleted)' notice next to artist name.
* Combine updater, updated at, and ip address fields in single column.
* Combine templates for standard listing and revert listing (only
  difference is presense of 'Revert to' column).
 2018-12-10 00:30:05 -06:00
evazion c75aef38ed set diff: fix obsolete_{added,removed} not including changed items. 2018-12-10 00:17:01 -06:00
evazion 161b3bb8ef diffs.scss: readd styles removed in e25e8d564. 
The <ins> and <del> tags are still used in /post_versions and /reports/upload_tags.
 2018-12-10 00:17:01 -06:00
evazion d213173d3d Fix #4002: Always include "updated by" line when creator != updater 2018-12-08 11:30:11 -06:00
evazion e25e8d564a artist versions: refactor diffs. 2018-12-07 12:45:51 -06:00
evazion 7ae27c370d Fix #3995: Automatically imply *_school_uniform -> school_uniform. 2018-12-05 12:19:27 -06:00
evazion 7bbe4e8ac1 moebooru: don't exclude artists from translated tags (#3969). 2018-12-05 11:53:26 -06:00
evazion fd2d56a388 Fix #3996: Some direct artstation urls cause the bookmarklet to fail. 
* Don't fail on urls that don't contain the project id (direct image urls).
* Don't fail when the work is deleted.
* Parse artist name from url when possible. This way the artist finder works on bad_artstation_id posts.
* Set canonical source url to `https://artist.artstation.com/projects/12345` instead of
  `https://www.artstation.com/artwork/1235` (this way we preserve the artist name).
* Cache api call.
* Include api call results in /source.json.
 2018-12-03 15:48:29 -06:00
evazion f00641b3ac Fix #3998: Some artist histories throw exceptions. 2018-12-02 11:45:57 -06:00
evazion 811bad5a86 /source.json: include raw api responses in output (#3940). 2018-11-30 00:19:00 -06:00
evazion e8c3d92696 Fix #3977: DeviantArt: Support new wixmp.com urls. 2018-11-30 00:10:59 -06:00
evazion 8da3474a8b Fix #3994: Some deviantart images mistakenly choosing preview image. 2018-11-29 23:01:08 -06:00
evazion 600b17cd9f Fix #3961: Tags in dialog boxes sometimes colored incorrectly 
Fix rules so that the `.ui-widget-content .category-0 a` rule for tags
overrides the `.ui-widget-content a` rule for normal links.
 2018-11-24 10:55:38 -06:00
evazion d82418ed43 Fix #3988: ordpool:<name> fails for large pools. 
Also fixes ordpool:<name> not returning all posts in the correct order
when searching for series pools that contain duplicate posts.
 2018-11-16 22:48:17 -06:00
evazion 41ff05c121 artists: convert other_names to array (#3987). 2018-11-15 14:31:16 -06:00
evazion 29fdfc42a4 pools/gallery: allow searching for collection pools (#3992). 
Default to showing only series pools when not doing a search. Otherwise,
when doing a search, show both series and collection pools.
 2018-11-15 12:22:51 -06:00
evazion 4fcb82f2e6 Fix #3991: Loading post #1604318 is broken. 
Fix exception in Pool#previous_post_id when the post id is not contained
in the pool.

This can happen when a post's pool_string lists the post as being in a
certain pool, but the post is not included in the pool's post_ids. Such
pool_string / post_ids inconsistencies exist because of past bugs.
 2018-11-15 10:28:20 -06:00
evazion 741462ae68 artist versions: convert other_names, url_string to arrays (#3987). 2018-11-14 14:25:02 -06:00
evazion fe2698a011 tag implications: convert descendant_names to array (#3987). 2018-11-14 12:51:18 -06:00
evazion 308a5021b4 wiki pages: convert other_names to array (#3987). 2018-11-13 19:18:11 -06:00
evazion b660aeefd7 application record: add array_attribute method. 
Add `array_attribute` method that defines helper methods for converting
array attributes to or from strings.
 2018-11-13 19:18:11 -06:00
evazion bea8c2a4b8 nijie: fix failure to handle certain image urls. 
Fix IMAGE_URL regex not matching urls of this form:

* https://pic04.nijie.info/nijie_picture/diff/main/287736_161475_20181112032855_1.png

This caused the illust id to not be parsed from the url, which led to `#image_url`
returning nil, which led to uploads failing because the url to download was missing.
 2018-11-12 18:04:07 -06:00
evazion 8f6c710c6b tests: fix translated tags test failures. 2018-11-12 18:04:07 -06:00
evazion 7524d52276 Fix #3985: Uploads: 405 Method Not Allowed. 2018-11-11 20:18:21 -06:00
evazion 6a7cd6ce8e Fix #3984: Twitter: undefined method `first' for nil:NilClass. 
Fix Sources::Strategies::Twitter#image_urls to return an empty array
instead of nil when the tweet doesn't contain any images.
 2018-11-11 17:41:32 -06:00
evazion a20eba9ef7 Fix #3983: Uploads: NoMethodError - undefined method `>=' for nil:NilClass 
* Rename Upload#download_for_upload to #get_file_for_upload.

* Fix #get_file_for_upload to raise error if no file or source url was given.

* Fix javascript upload validation to disallow submitting form if file is
  not present and the source is not an url.
 2018-11-11 17:12:39 -06:00
evazion e10c6c6a30 Fix #3982: Uploads: URI::InvalidURIError - URI must be ascii only. 2018-11-11 12:17:58 -06:00
evazion eade33fa7c Fix #3981: Inconsistency between posts and pools. 2018-11-10 12:37:08 -06:00
evazion e69cbe7f81 pools: post_count fixups. 2018-11-08 19:35:17 -06:00
evazion fb7d83c54f pools: drop post_count column (fix #3667) 2018-11-08 15:35:41 -06:00
evazion 115ed16a96 pools: store post_ids as array instead of string (fix #3979) 2018-11-08 15:09:31 -06:00
evazion 572645d888 pools: cleanup unneeded code. 
* create_mod_action_for_destroy didn't exist (pools are never destroyed).

* is_active and is_deleted are already initialized via database defaults.

* creator_name is already defined by belongs_to_creator.

* Returning true/false in validations does nothing.
 2018-11-07 16:10:36 -06:00
evazion 1281481548 Fix #3978: Pool name/category validations not being enforced. 2018-11-07 16:10:16 -06:00
evazion a6aa75873d Fix #3976: DText external links appear broken. 2018-11-06 20:17:45 -06:00
evazion ed47db0e48 upload tags report: add controller test (#3975). 2018-11-06 18:29:27 -06:00
evazion 5c4a310589 Fix #3975: Upload tags report is broken. 2018-11-06 18:18:18 -06:00
evazion bd0bb658b8 Fix #3974: Pool galleries: link thumbnails to pools instead of posts. 2018-11-06 14:33:04 -06:00
evazion 841104f09a post presenter: fixup typo in 26c1eadf. 2018-11-06 13:15:09 -06:00
evazion ff9ce25b01 Fix #3973: Pool gallery is broken. 2018-11-06 13:11:11 -06:00
evazion 26c1eadf6a modqueue: move score highlighting from js to presenter. 
The 'post-has-children' class was dropped because it was unused
('post-status-has-children' is already added elsewhere).
 2018-11-06 10:42:48 -06:00
evazion 2eb284f31e modqueue: simplify detailed rejection dialog js. 2018-11-06 10:42:48 -06:00
evazion b730a86870 modqueue: clear detailed rejection form before each use. 
Bug: in the modqueue, if a user does a detailed rejection of one post,
then tries to do a detailed rejection of another post, the form will
still be filled in with the rejection message from the previous post.
 2018-11-06 10:42:48 -06:00
evazion 00f36605c4 modqueue: fix typo in 1d3eb584c 2018-11-05 17:27:33 -06:00
evazion 1cba439589 Fix #3971: Keyboard navigation inside pools is broken. 2018-11-05 13:04:21 -06:00
evazion 5b3f3253a4 related tags: fix broken translated tag names 
ref: https://danbooru.donmai.us/forum_topics/9127?page=261#forum_post_152040
 2018-11-05 12:54:53 -06:00
evazion 98cffc310b Fix pool elements controller tests. 2018-11-04 21:25:25 -06:00
evazion 29b6121a07 pools: refactor #neighbors + fix broken #neighbors tests. 2018-11-04 19:40:57 -06:00
evazion 628341f7f0 Fix #3969: Translated tags should ignore artist tags. 2018-11-04 17:07:35 -06:00
evazion 19b92acabc Fix #3970: Make "Copy all notes" not builder exclusive. 2018-11-04 16:42:55 -06:00
evazion 0152cbe39e moebooru: fix delegation to nil strategy (fixup for 5cf6a43). 2018-11-04 15:24:22 -06:00
evazion c7e6c2a44a posts: fix pixiv id parsing (fixup for 5cf6a43) 2018-11-04 14:22:29 -06:00